Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[API cleanup] security should be dropped from the public api #1843

Closed
garlick opened this issue Nov 18, 2018 · 1 comment
Closed

[API cleanup] security should be dropped from the public api #1843

garlick opened this issue Nov 18, 2018 · 1 comment
Assignees
@garlick

Comments

@garlick
Copy link
Member

garlick commented Nov 18, 2018

The code in libflux/security is used by flux-keygen and the broker and that's about it. It's old code that needs a makeover and since it doesn't need to be public, let's make it private.
@SteVwonder
Copy link
Member

SteVwonder commented Nov 19, 2018 •
edited
Loading

There is also python bindings in python/flux/sec.py (I don't think anything uses them).

garlick added a commit to garlick/flux-core that referenced this issue Nov 19, 2018
@garlick
libutil/zsecurity: make zmq security class private
e1599f8 
Problem: the flux_sec_t "class" is only used by the
broker and flux-keygen, and should be removed from
the public API.

Relocate to libutil/zsecurity.

Fixes flux-framework#1843
garlick added a commit to garlick/flux-core that referenced this issue Nov 19, 2018
@garlick
libutil/zsecurity: make zmq security class private
3710d6c 
Problem: the flux_sec_t "class" is only used by the
broker and flux-keygen, and should be removed from
the public API.

Relocate to libutil/zsecurity.

Fixes flux-framework#1843
@garlick garlick mentioned this issue Nov 19, 2018
Merged
@garlick garlick self-assigned this Nov 19, 2018
garlick added a commit to garlick/flux-core that referenced this issue Nov 19, 2018
@garlick
libutil/zsecurity: make zmq security class private
45597d9 
Problem: the flux_sec_t "class" is only used by the
broker and flux-keygen, and should be removed from
the public API.

Relocate to libutil/zsecurity.

Fixes flux-framework#1843
@grondo grondo closed this as completed in e098c8b Nov 20, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@garlick garlick

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@garlick @SteVwonder