Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

jsc,job,wreck: change key from lwj to jobid for consistency #1409

Merged
merged 1 commit into from
Apr 1, 2018

Conversation

SteVwonder
Copy link
Member

fixes: #1408

@coveralls
Copy link

coveralls commented Apr 1, 2018

Coverage Status

Coverage decreased (-0.003%) to 78.885% when pulling 2e24286 on SteVwonder:fix1408 into 4a51fe1 on flux-framework:master.

@codecov-io
Copy link

codecov-io commented Apr 1, 2018

Codecov Report

Merging #1409 into master will decrease coverage by <.01%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master    #1409      +/-   ##
==========================================
- Coverage   78.58%   78.57%   -0.01%     
==========================================
  Files         163      163              
  Lines       29995    29995              
==========================================
- Hits        23571    23570       -1     
- Misses       6424     6425       +1
Impacted Files Coverage Δ
src/modules/wreck/wrexecd.c 75.77% <ø> (ø) ⬆️
src/modules/wreck/job.c 72.47% <ø> (ø) ⬆️
src/common/libjsc/jstatctl.c 74.89% <100%> (ø) ⬆️
src/broker/modservice.c 79.61% <0%> (-0.98%) ⬇️
src/broker/overlay.c 74.14% <0%> (-0.63%) ⬇️
src/common/libflux/handle.c 83.66% <0%> (-0.5%) ⬇️
src/common/libkvs/kvs_watch.c 90.98% <0%> (-0.43%) ⬇️
src/common/libflux/message.c 81.48% <0%> (ø) ⬆️
src/cmd/flux-module.c 85.36% <0%> (+0.3%) ⬆️
src/common/libflux/mrpc.c 86.66% <0%> (+1.17%) ⬆️
... and 1 more

@garlick
Copy link
Member

garlick commented Apr 1, 2018

Thanks! Needs a rebase.

Does sched need to be updated to match this or is this change contained in core?

@SteVwonder
Copy link
Member Author

This change is contained with core. Rebase coming up!

@grondo
Copy link
Contributor

grondo commented Apr 1, 2018

Thanks for taking care of this @SteVwonder

@garlick garlick merged commit 7f04a25 into flux-framework:master Apr 1, 2018
@SteVwonder SteVwonder deleted the fix1408 branch April 2, 2018 20:17
@grondo grondo mentioned this pull request May 10, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

lwj vs jobid as job ID key in various JSON payloads
5 participants