lwj vs jobid as job ID key in various JSON payloads

[SteVwonder]

In the wreck.state.* and jsc.state.* events , the job ID has the key lwj. In the sched.cancel, job.create, job.submit, and job.submit-nocreate RPCs, the request/response use jobid as the key for the job ID.

I found this inconsistency confusing while working on flux-framework/flux-sched#303. job.submit-nocreate consumes a request containing jobid and then emits an event with the lwj key.

For consistency, I recommend changing the events to use jobid for the key rather than lwj. Thoughts?

[grondo]

Great observation, sorry about the inconsistency. I'm all for fixing it!

[SteVwonder]

Cool! I can submit a PR to core along with my emulator fix PR to sched.

[grondo]

Thanks @SteVwonder!

[dongahn]

I agree! We should try to avoid the term lwj at this point?

[grondo]

We should try to avoid the term lwj at this point?

Sure, but:

grondo@moron:~/git/flux-core$ git grep lwj | wc -l
222

Maybe we be sure to drop the term in the wreck replacement? 😄