kvs: minor fixes/cleanup #1342
Merged
kvs: minor fixes/cleanup #1342
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rename to fence_add_request_ops(), which makes more sense.
Remove unnecessary branch check, as ops array is always non-NULL (but can be an empty array).
Check that name is not NULL and nprocs is > 0.
|
not entirely sure why travis hasn't started this yet, is there a way to kick it? |
|
You might have to make a minor change and re-push, unless the PR has already been built at least once at https://travis-ci.org/flux-framework/flux-core/pull_requests, in which case you can restart the build via the travis interface there. |
Check that name is not NULL and nprocs is > 0.
chu11
force-pushed
the
issue1337-part1
branch
from
1425e3a to
134370e
Compare
|
did a tiny change and that seems to have done it. |
|
hit a #1150, restarted build |
|
then I hit #1077, restart build |
|
Looks good, thanks! |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Minor things I fixed up on the way to fixing #1337.