modules/kvs: Add fence_create() input check

Check that name is not NULL and nprocs is > 0.
flux-framework · Feb 20, 2018 · 134370e · 134370e
1 parent c101d1d
commit 134370e
Show file tree

Hide file tree

Showing 2 changed files with 16 additions and 11 deletions.
diff --git a/src/modules/kvs/fence.c b/src/modules/kvs/fence.c
@@ -60,10 +60,14 @@ void fence_destroy (fence_t *f)
 
 fence_t *fence_create (const char *name, int nprocs, int flags)
 {
-    fence_t *f;
+    fence_t *f = NULL;
     json_t *s = NULL;
     int saved_errno;
 
+    if (!name || nprocs <= 0) {
+        saved_errno = EINVAL;
+        goto error;
+    }
     if (!(f = calloc (1, sizeof (*f)))
         || !(f->ops = json_array ())
         || !(f->names = json_array ())
@@ -74,16 +78,14 @@ fence_t *fence_create (const char *name, int nprocs, int flags)
     f->nprocs = nprocs;
     f->flags = flags;
     f->aux_int = 0;
-    if (name) {
-        if (!(s = json_string (name))) {
-            saved_errno = ENOMEM;
-            goto error;
-        }
-        if (json_array_append_new (f->names, s) < 0) {
-            json_decref (s);
-            saved_errno = ENOMEM;
-            goto error;
-        }
+    if (!(s = json_string (name))) {
+        saved_errno = ENOMEM;
+        goto error;
+    }
+    if (json_array_append_new (f->names, s) < 0) {
+        json_decref (s);
+        saved_errno = ENOMEM;
+        goto error;
     }
 
     return f;

diff --git a/src/modules/kvs/test/fence.c b/src/modules/kvs/test/fence.c
@@ -35,6 +35,9 @@ void basic_api_tests (void)
     flux_msg_t *request;
     int count = 0;
 
+    ok (fence_create (NULL, 0, 0) == NULL,
+        "fence_create fails on bad input");
+
     ok ((f = fence_create ("foo", 1, 3)) != NULL,
         "fence_create works");