modules/kvs: Refactor lookup_create() #1300
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove root_dir parameter to lookup_create(). It was only used for one corner case, which in reality is not needed. Instead, when user passes in root dir path (i.e. "."), it will return the root reference that was passed in by the user. It does not need to return the "real" root reference. Update unit tests appropriately. Fixes flux-framework#1297
|
hit #1150, restart build |
Codecov Report
@@ Coverage Diff @@
## master #1300 +/- ##
==========================================
+ Coverage 78.21% 78.23% +0.01%
==========================================
Files 154 154
Lines 27941 27931 -10
==========================================
- Hits 21855 21851 -4
+ Misses 6086 6080 -6
|
|
LGTM! |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove root_dir parameter to lookup_create(). It was only used
for one corner case, which in reality is not needed.
Instead, when user passes in root dir path (i.e. "."), it will return
the root reference that was passed in by the user. It does not need
to return the "real" root reference.
Update unit tests appropriately.
Fixes #1297