You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Was talking to @garlick and he was wondering why in lookup_create() there is a root_dir and a root_ref argument.
lookup_t *lookup_create (struct cache *cache,
int current_epoch,
const char *root_dir,
const char *root_ref,
const char *path,
flux_t *h,
int flags);
I remembered it was for a specific corner case where the user passes in a at-reference via lookupat and the user specifies as key of .. The current code returns the "real root reference" as a response. It should instead return the at-reference.
As a consequence of this fix, we can eliminate one of the above arguments in lookup.
The text was updated successfully, but these errors were encountered:
Remove root_dir parameter to lookup_create(). It was only used
for one corner case, which in reality is not needed.
Instead, when user passes in root dir path (i.e. "."), it will return
the root reference that was passed in by the user. It does not need
to return the "real" root reference.
Update unit tests appropriately.
Fixesflux-framework#1297
Was talking to @garlick and he was wondering why in
lookup_create()
there is aroot_dir
and aroot_ref
argument.I remembered it was for a specific corner case where the user passes in a at-reference via
lookupat
and the user specifies as key of.
. The current code returns the "real root reference" as a response. It should instead return the at-reference.As a consequence of this fix, we can eliminate one of the above arguments in lookup.
The text was updated successfully, but these errors were encountered: