testsuite: sharness sync #206
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Problem: flux-sharness.sh is out of date with flux-core, where it came from. Also, there are HAVE_JQ prereqs on many test cases, but flux-core requires JQ for all tests, so the testsuite for this repo could have the same requirement. Update to require JQ for the entire testsuite by pulling in some changes to flux-sharness.sh from flux-core.
Problem: many tests have a jq prereq, but JQ is now required for the entire testsuite. Drop the prereq on individual tests.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As @grondo mentioned here, we can make
jqa prereq for the entire testsuite and drop theHAVE_JQprereq from individual test cases.