Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update expected jgf #207

Merged
merged 1 commit into from
Sep 5, 2024
Merged

Update expected jgf #207

merged 1 commit into from
Sep 5, 2024

Conversation

jameshcorbett
Copy link
Member

@jameshcorbett jameshcorbett commented Sep 4, 2024 •
edited
Loading

Problem: flux-framework/flux-sched#1286 changed the way edges
are represented in JGF.

Update the expected JGF output of flux-dws2jgf.

@jameshcorbett
test: update expected JGF
a3991b4 
Problem: flux-framework/flux-sched/pull/1286 changed the way edges
are represented in JGF.

Update the expected JGF output of flux-dws2jgf.
cmoussa1
cmoussa1 approved these changes Sep 5, 2024
View reviewed changes
Copy link
Member

@cmoussa1 cmoussa1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! You might consider adding a short PR description as well. :-)

@jameshcorbett
Copy link
Member Author

Thanks! Done and setting MWP.

@mergify mergify bot merged commit ea06a5c into flux-framework:master Sep 5, 2024
8 checks passed
@jameshcorbett jameshcorbett deleted the update-expected-jgf branch September 5, 2024 17:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cmoussa1 cmoussa1 cmoussa1 approved these changes

Assignees
No one assigned
Labels
merge-when-passing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jameshcorbett @cmoussa1