-
Notifications
You must be signed in to change notification settings - Fork 9.8k
[video_player]add http headers option when loading network data source #953
[video_player]add http headers option when loading network data source #953
Conversation
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here (e.g. What to do if you already signed the CLAIndividual signers
Corporate signers
|
I signed it! |
CLAs look good, thanks! |
Hi, thank you for trying to finally fix flutter/flutter#16466. There is already a very similar PR open here #897. The problem seems to be the usage of |
This comment was marked as abuse.
This comment was marked as abuse.
I really need this feature for my project. Unfortunately this PR seems abandoned. Any chance in getting it resumed? |
See comments in feature request flutter/flutter#16466 and a similar pr #897 If I were you and you really need it, fork the repo, apply one of the prs (will have to update a little I am sure), and move on. You will have to merge in changes from the main repo though whenever you want the latest (see https://help.github.com/en/github/collaborating-with-issues-and-pull-requests/merging-an-upstream-repository-into-your-fork). |
Can someone resolve the conflicts and merge it. That is very useful feature! |
Closing, as there is already #897 which addresses the same issue; let's consolidate discussion there. |
I added optional request headers to VideoPlayerController.network contructor for video_player plugin. I did not see an obvious place to create a test for these changes, but happy to do so if you would like. I did manually test these changes on iOS and Android emulator.