Skip to content
This repository has been archived by the owner on Feb 22, 2023. It is now read-only.

[video_player]Added HTTP headers setting to video_player plugin #897

Closed
wants to merge 1 commit into from

Conversation

Yarikk26
Copy link

Not the best solution for flutter/flutter#16466 especially for iOS.
It seems that there is the only one way to set headers for iOS player, but it isn't public (https://stackoverflow.com/a/23713028).

@Yarikk26 Yarikk26 force-pushed the videoplayer_http_headers branch from 5f4452c to 1bc99e9 Compare January 30, 2019 12:58
@cyanglaz cyanglaz changed the title Added HTTP headers setting to video_player plugin [video_player]Added HTTP headers setting to video_player plugin Feb 22, 2019
@JohnGalt1717

This comment was marked as abuse.

@JohnGalt1717

This comment was marked as abuse.

@Yarikk26
Copy link
Author

@JohnGalt1717 You can add something like this into your pubspec.yaml:

video_player:
  git:
    url: https://github.com/tvip/flutter-plugins.git
    ref: videoplayer_http_headers #branch or commit hash here
    path: packages/video_player

You can also specify branch tvip in ref field. There are some more additions from me in that branch, but it's a bit outdated(feb 2019). There is the one more way: you can fork this repo and merge my changes into yours copy and use it. :)

@JohnGalt1717

This comment was marked as abuse.

@JohnGalt1717

This comment was marked as abuse.

@JohnGalt1717

This comment was marked as abuse.

@praxder
Copy link

praxder commented Jan 3, 2020

I'm also very interested in getting widevine and fairplay working. Any updates on when this might get merged?

@dvirgiln
Copy link

dvirgiln commented Mar 7, 2020

I really need this functionality as well. This PR has been open for one and a half years. Any idea when this will be merged?

@JohnGalt1717

This comment was marked as abuse.

@vishnukvmd
Copy link

FWIW, react-native-video ran into a similar issue, and decided to go ahead with an implementation using the AVURLAssetHTTPHeaderFieldsKey, similar to what's proposed here: TheWidlarzGroup/react-native-video#2014

I'd say that this is a pragmatic way to solve this problem.

@stuartmorgan
Copy link
Contributor

We apologize for the long delay in triaging this PR. We’re in the process of overhauling our PR triage system to respond much more quickly, as well as working through the backlog.

We’re currently working through a large backlog of PRs. As explained in CONTRIBUTING.md, votes for the corresponding issue are the primary way we’re prioritizing non-trivial reviews; this addresses a fairly highly-voted issue, so is something we can work on moving forward. In order for that to happen, the PR will need:

  • Updating to changes in plugin structure on master (e.g., federation)
  • Tests (at least unit tests of the app-facing->plugin interface portion of the change)

@Yarikk26 If you're still interested in moving forward with this, once you've done the above please comment and I'll route this to a reviewer. If not, perhaps someone else will be interested in taking over in a new PR.

@stuartmorgan
Copy link
Contributor

Given the lack of response to the last comment, and the new PR, I'm going to close this in favor of the new PR.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants