Skip to content
This repository has been archived by the owner on Feb 22, 2023. It is now read-only.

Switch ios_platform_tests from Cirrus to LUCI #6729

Merged
merged 2 commits into from
Nov 22, 2022

Conversation

keyonghan
Copy link
Contributor

@keyonghan keyonghan commented Nov 21, 2022

Follow up of #6682 to switch ios_platform_tests from Cirrus to LUCI completely.

These tasks are running green consistently:
Screen Shot 2022-11-21 at 10 27 42 AM

Part of flutter/flutter#114373

Copy link
Contributor

@stuartmorgan stuartmorgan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Could you do a quick change to mirror the recent changes you've made to the plugins recipe (script arguments, sharding env variable, etc.) to the packages repo recipe? I'm actively working on synchronizing the flutter/plugins and flutter/packages CI in preparation for the repo merge, and realized that I can't spin up these new LUCI tests there without recipe changes.

@keyonghan
Copy link
Contributor Author

LGTM!

Could you do a quick change to mirror the recent changes you've made to the plugins recipe (script arguments, sharding env variable, etc.) to the packages repo recipe? I'm actively working on synchronizing the flutter/plugins and flutter/packages CI in preparation for the repo merge, and realized that I can't spin up these new LUCI tests there without recipe changes.

Sure. Script args support: https://flutter-review.git.corp.google.com/c/recipes/+/36541.
As sharding env is handled in modules, packages recipe picks it up naturally and no more action is needed here.

@keyonghan
Copy link
Contributor Author

Seems the tree is closed. Is there a bug tracking it? Let me know if you need a bug to track /cc @stuartmorgan

@stuartmorgan
Copy link
Contributor

stuartmorgan commented Nov 22, 2022

Looks like it's open now; there may have been a flaky failure.

@keyonghan keyonghan added the autosubmit Merge PR when tree becomes green via auto submit App label Nov 22, 2022
@auto-submit auto-submit bot merged commit e484dec into flutter:main Nov 22, 2022
josh88versa pushed a commit to versa-asia/plugins that referenced this pull request Nov 23, 2022
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Nov 23, 2022
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Nov 23, 2022
auto-submit bot pushed a commit to flutter/flutter that referenced this pull request Nov 23, 2022
* 2a5239495 [ci] Import flutter/packages install_chromium.sh (flutter/plugins#6727)

* e484dec84 Switch `ios_platform_tests` from Cirrus to LUCI (flutter/plugins#6729)

* fb0a593d6 Roll Flutter from 2962228 to 06d90b8 (17 revisions) (flutter/plugins#6742)

* dd493f5b1 [path_provider] Remove unused Guava dependency (flutter/plugins#6744)

* b2d4ee5ce [google_sign_in] Roll Guava dependency to 31.1 (flutter/plugins#6746)

* be855018f [ios_platform_images] remove deprecated APIs (flutter/plugins#6693)

* a431b35bf Roll Flutter from 06d90b8 to 0eb2d51 (17 revisions) (flutter/plugins#6750)
shogohida pushed a commit to shogohida/flutter that referenced this pull request Dec 7, 2022
…#115930)

* 2a5239495 [ci] Import flutter/packages install_chromium.sh (flutter/plugins#6727)

* e484dec84 Switch `ios_platform_tests` from Cirrus to LUCI (flutter/plugins#6729)

* fb0a593d6 Roll Flutter from 2962228 to 06d90b8 (17 revisions) (flutter/plugins#6742)

* dd493f5b1 [path_provider] Remove unused Guava dependency (flutter/plugins#6744)

* b2d4ee5ce [google_sign_in] Roll Guava dependency to 31.1 (flutter/plugins#6746)

* be855018f [ios_platform_images] remove deprecated APIs (flutter/plugins#6693)

* a431b35bf Roll Flutter from 06d90b8 to 0eb2d51 (17 revisions) (flutter/plugins#6750)
gspencergoog pushed a commit to gspencergoog/flutter that referenced this pull request Jan 19, 2023
…#115930)

* 2a5239495 [ci] Import flutter/packages install_chromium.sh (flutter/plugins#6727)

* e484dec84 Switch `ios_platform_tests` from Cirrus to LUCI (flutter/plugins#6729)

* fb0a593d6 Roll Flutter from 2962228 to 06d90b8 (17 revisions) (flutter/plugins#6742)

* dd493f5b1 [path_provider] Remove unused Guava dependency (flutter/plugins#6744)

* b2d4ee5ce [google_sign_in] Roll Guava dependency to 31.1 (flutter/plugins#6746)

* be855018f [ios_platform_images] remove deprecated APIs (flutter/plugins#6693)

* a431b35bf Roll Flutter from 06d90b8 to 0eb2d51 (17 revisions) (flutter/plugins#6750)
mauricioluz pushed a commit to mauricioluz/plugins that referenced this pull request Jan 26, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
autosubmit Merge PR when tree becomes green via auto submit App
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants