Skip to content
This repository has been archived by the owner on Feb 22, 2023. It is now read-only.

[ios_platform_images] remove deprecated APIs #6693

Merged
merged 7 commits into from
Nov 23, 2022
Merged

[ios_platform_images] remove deprecated APIs #6693

merged 7 commits into from
Nov 23, 2022

Conversation

jonahwilliams
Copy link
Member

@jonahwilliams jonahwilliams commented Nov 12, 2022 •
edited
Loading

These APIs were deprecated before the last stable release, and will be removed in a future release of Flutter

@flutter-dashboard
Copy link

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!).

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

@Hixie
Copy link
Contributor

Hixie commented Nov 14, 2022

test-exempt: code refactor with no semantic change

jmagman
jmagman approved these changes Nov 15, 2022
View reviewed changes
Copy link
Member

@jmagman jmagman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The deprecation details are at https://docs.flutter.dev/release/breaking-changes/image-provider-load-buffer.

LGTM

packages/ios_platform_images/pubspec.yaml

environment:
sdk: ">=2.14.0 <3.0.0"
flutter: ">=2.10.0"
flutter: ">=3.3.0"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@stuartmorgan said upping to 3.3 was okay per trailing stable policies in flutter/flutter#101965 (comment).

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, this is also documented at https://github.com/flutter/flutter/wiki/Contributing-to-Plugins-and-Packages#supported-flutter-versions

@jonahwilliams jonahwilliams added the autosubmit Merge PR when tree becomes green via auto submit App label Nov 15, 2022
stuartmorgan
stuartmorgan reviewed Nov 15, 2022
View reviewed changes
packages/ios_platform_images/CHANGELOG.md Outdated
@@ -1,6 +1,7 @@
## NEXT
## 0.3.0
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be 0.2.1, since 0.3.0 is a breaking change in Dart semver (it shifts everything down one for <1.0 versions).

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done!

stuartmorgan
stuartmorgan approved these changes Nov 15, 2022
View reviewed changes
Copy link
Contributor

@stuartmorgan stuartmorgan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@auto-submit auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Nov 16, 2022
@auto-submit
Copy link

auto-submit bot commented Nov 16, 2022

auto label is removed for flutter/plugins, pr: 6693, due to - The status or check suite ios-build_all_plugins CHANNEL:stable has failed. Please fix the issues identified (or deflake) before re-applying this label.

@stuartmorgan
Copy link
Contributor

There was a scheduling issue with Cirrus macOS machines; trying a re-run now in the hopes that it's cleared up.

@jonahwilliams jonahwilliams added the autosubmit Merge PR when tree becomes green via auto submit App label Nov 16, 2022
@auto-submit auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Nov 17, 2022
@auto-submit
Copy link

auto-submit bot commented Nov 17, 2022

auto label is removed for flutter/plugins, pr: 6693, Failed to merge pr#: 6693 with Pull request could not be merged: Required status check "ci.yaml validation" is expected..

@jonahwilliams jonahwilliams added the autosubmit Merge PR when tree becomes green via auto submit App label Nov 18, 2022
@auto-submit
Copy link

auto-submit bot commented Nov 18, 2022

auto label is removed for flutter/plugins, pr: 6693, Failed to merge pr#: 6693 with Pull request could not be merged: Required status check "ci.yaml validation" is expected..

@auto-submit auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Nov 18, 2022
@jonahwilliams
Copy link
Member Author

How do I fix this?

@stuartmorgan
Copy link
Contributor

Try merging the latest main in again to re-trigger tests. AFAIK there's no way to manually re-run ci.yaml validation, unfortunately.

@jonahwilliams jonahwilliams added the autosubmit Merge PR when tree becomes green via auto submit App label Nov 23, 2022
@auto-submit auto-submit bot merged commit be85501 into main Nov 23, 2022
josh88versa pushed a commit to versa-asia/plugins that referenced this pull request Nov 23, 2022
@jonahwilliams @josh88versa
[ios_platform_images] remove deprecated APIs (flutter#6693)
4dd4676 
* [ios_platform_images] remove deprecated APIs

* ++

* ++

* ++

* Update pubspec.yaml

* Update CHANGELOG.md
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Nov 23, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Nov 23, 2022
@engine-flutter-autoroll
be855018f [ios_platform_images] remove deprecated APIs (flutter/plugi…
783a978 
…ns#6693)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Nov 23, 2022
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Nov 23, 2022
@engine-flutter-autoroll
be855018f [ios_platform_images] remove deprecated APIs (flutter/plugi…
6db8c93 
…ns#6693)
auto-submit bot pushed a commit to flutter/flutter that referenced this pull request Nov 23, 2022
@engine-flutter-autoroll
Roll Plugins from 5d847ef391a5 to a431b35bfa0b (7 revisions) (#115930)
16fb711 
* 2a5239495 [ci] Import flutter/packages install_chromium.sh (flutter/plugins#6727)

* e484dec84 Switch `ios_platform_tests` from Cirrus to LUCI (flutter/plugins#6729)

* fb0a593d6 Roll Flutter from 2962228 to 06d90b8 (17 revisions) (flutter/plugins#6742)

* dd493f5b1 [path_provider] Remove unused Guava dependency (flutter/plugins#6744)

* b2d4ee5ce [google_sign_in] Roll Guava dependency to 31.1 (flutter/plugins#6746)

* be855018f [ios_platform_images] remove deprecated APIs (flutter/plugins#6693)

* a431b35bf Roll Flutter from 06d90b8 to 0eb2d51 (17 revisions) (flutter/plugins#6750)
shogohida pushed a commit to shogohida/flutter that referenced this pull request Dec 7, 2022
@engine-flutter-autoroll @shogohida
Roll Plugins from 5d847ef391a5 to a431b35bfa0b (7 revisions) (flutter…
07fab5f 
…#115930)

* 2a5239495 [ci] Import flutter/packages install_chromium.sh (flutter/plugins#6727)

* e484dec84 Switch `ios_platform_tests` from Cirrus to LUCI (flutter/plugins#6729)

* fb0a593d6 Roll Flutter from 2962228 to 06d90b8 (17 revisions) (flutter/plugins#6742)

* dd493f5b1 [path_provider] Remove unused Guava dependency (flutter/plugins#6744)

* b2d4ee5ce [google_sign_in] Roll Guava dependency to 31.1 (flutter/plugins#6746)

* be855018f [ios_platform_images] remove deprecated APIs (flutter/plugins#6693)

* a431b35bf Roll Flutter from 06d90b8 to 0eb2d51 (17 revisions) (flutter/plugins#6750)
gspencergoog pushed a commit to gspencergoog/flutter that referenced this pull request Jan 19, 2023
@engine-flutter-autoroll @gspencergoog
Roll Plugins from 5d847ef391a5 to a431b35bfa0b (7 revisions) (flutter…
dab6019 
…#115930)

* 2a5239495 [ci] Import flutter/packages install_chromium.sh (flutter/plugins#6727)

* e484dec84 Switch `ios_platform_tests` from Cirrus to LUCI (flutter/plugins#6729)

* fb0a593d6 Roll Flutter from 2962228 to 06d90b8 (17 revisions) (flutter/plugins#6742)

* dd493f5b1 [path_provider] Remove unused Guava dependency (flutter/plugins#6744)

* b2d4ee5ce [google_sign_in] Roll Guava dependency to 31.1 (flutter/plugins#6746)

* be855018f [ios_platform_images] remove deprecated APIs (flutter/plugins#6693)

* a431b35bf Roll Flutter from 06d90b8 to 0eb2d51 (17 revisions) (flutter/plugins#6750)
mauricioluz pushed a commit to mauricioluz/plugins that referenced this pull request Jan 26, 2023
@jonahwilliams @mauricioluz
[ios_platform_images] remove deprecated APIs (flutter#6693)
a6c528a 
* [ios_platform_images] remove deprecated APIs

* ++

* ++

* ++

* Update pubspec.yaml

* Update CHANGELOG.md
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@stuartmorgan stuartmorgan stuartmorgan approved these changes

@jmagman jmagman jmagman approved these changes

Assignees
No one assigned
Labels
autosubmit Merge PR when tree becomes green via auto submit App needs tests p: ios_platform_images
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jonahwilliams @Hixie @stuartmorgan @jmagman