Exclude null-safe plugins from testing on stable #3318

blasten · 2020-12-10T19:29:03Z

Mechanism for disabling the checks on Flutter stable. This needs a PR to the tool.

amirh

Thanks!!

Generally I'm pushing to do as little as possible in these shell scripts (and ideally move all the logic from here to the flutter_plugin_tools), this is so all of our tests can run on all environments (e.g windows hosts). But as this is a net-improvement and high priority I'm ok with landing it once it works.

amirh · 2020-12-10T20:31:35Z

script/incremental_build.sh

+ALL_EXCLUDED=("")
+# Exclude nnbd plugins from stable.
+if [[ "$CHANNEL" -eq "stable" ]]; then
+  ALL_EXCLUDED=($EXCLUDED_PLUGINS_FROM_STABLE)


nit: can you print to the log here that we're skipping checks for the following plugins?

amirh · 2020-12-10T20:35:26Z

script/incremental_build.sh

@@ -39,18 +47,18 @@ PLUGIN_SHARDING=($PLUGIN_SHARDING)

 if [[ "${BRANCH_NAME}" == "master" ]]; then
  echo "Running for all packages"
-  (cd "$REPO_DIR" && $PUB global run flutter_plugin_tools "${ACTIONS[@]}" ${PLUGIN_SHARDING[@]})
+  (cd "$REPO_DIR" && $PUB global run flutter_plugin_tools "${ACTIONS[@]}" --exclude="$ALL_EXCLUDED" ${PLUGIN_SHARDING[@]})


does flutter_plugin_tools support --exclude?

PR: https://github.com/flutter/plugin_tools/pull/124

amirh

LGTM!

* master: [q-w] Update Flutter SDK constraint (flutter#3323) [i-p] Update Flutter SDK constraint (flutter#3322) [d-g] Update Flutter SDK constraint (flutter#3321) [a-c] Update Flutter SDK constraint (flutter#3320) [image_picker_platform_interface] Pass Uri to package:http APIs (flutter#3309) Exclude null-safe plugins from testing on stable (flutter#3318) [documentation] [url_launcher] fix for readme code sample (flutter#3308) # Conflicts: # packages/webview_flutter/CHANGELOG.md

…gins#3318)

…m-changes * upstream-share-final-null-release: (233 commits) [q-w] Update Flutter SDK constraint (flutter#3323) [i-p] Update Flutter SDK constraint (flutter#3322) [d-g] Update Flutter SDK constraint (flutter#3321) [a-c] Update Flutter SDK constraint (flutter#3320) [image_picker_platform_interface] Pass Uri to package:http APIs (flutter#3309) Exclude null-safe plugins from testing on stable (flutter#3318) [documentation] [url_launcher] fix for readme code sample (flutter#3308) [camera] Add zoom support to platform interface (flutter#3312) update analysis options for nnbd (flutter#3319) [camera] Suppress unchecked cast warning in java test (flutter#3316) [image_picker] [integration_test] Fixes to make the tree green (flutter#3317) [camera] Expanded platform interface to support setting flash mode (flutter#3313) [Espresso] Android Code Inspection and Clean up (flutter#3111) [camera] Add `camera_platform_interface` package (flutter#3253) [camera] Support Android 30 (flutter#3299) bump integration test to 1.0.0 (flutter#3295) [android_alarm_manager] fix AndroidManifest.xml for android lint issue "XML tag has empty body" (flutter#3288) Use testWidgets instead of test to fix failures not surfacing on CI (flutter#3279) [file_selector_platform_interface] Migrate to cross_file package (flutter#3286) Fix broken link (flutter#3280) ...

Exclude nnbd plugins from testing on stable

7cf970b

blasten requested a review from amirh December 10, 2020 19:29

google-cla bot added the cla: yes label Dec 10, 2020

;

96e5f11

amirh reviewed Dec 10, 2020

View reviewed changes

Add debugging info

33525ff

blasten requested a review from amirh December 10, 2020 23:58

amirh approved these changes Dec 11, 2020

View reviewed changes

Emmanuel Garcia added 2 commits December 11, 2020 12:02

Retrigger

888fa34

Merge branch 'master' into exclude_nnbd_plugins

69bfc6a

blasten merged commit 6870b08 into flutter:master Dec 11, 2020

blasten deleted the exclude_nnbd_plugins branch December 11, 2020 22:26

blasten mentioned this pull request Dec 11, 2020

[webview_flutter] Migrate to null-safety #3310

Closed

12 tasks

engine-flutter-autoroll mentioned this pull request Dec 14, 2020

Roll Plugins from 7d392476ac20 to 0b158bd73e99 (8 revisions) flutter/flutter#72286

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Dec 14, 2020

6870b08 Exclude null-safe plugins from testing on stable (flutter/plu…

8206f38

…gins#3318)

engine-flutter-autoroll mentioned this pull request Dec 14, 2020

Roll Plugins from 7d392476ac20 to ad6d03c13ba5 (9 revisions) flutter/flutter#72299

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Dec 14, 2020

6870b08 Exclude null-safe plugins from testing on stable (flutter/plu…

2f4c298

…gins#3318)

engine-flutter-autoroll mentioned this pull request Dec 15, 2020

Roll Plugins from 7d392476ac20 to 78eff18ff7f8 (10 revisions) flutter/flutter#72356

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Dec 15, 2020

6870b08 Exclude null-safe plugins from testing on stable (flutter/plu…

2058232

…gins#3318)

engine-flutter-autoroll mentioned this pull request Dec 15, 2020

Roll Plugins from 7d392476ac20 to 88466ff7325a (11 revisions) flutter/flutter#72359

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Dec 15, 2020

6870b08 Exclude null-safe plugins from testing on stable (flutter/plu…

b06f215

…gins#3318)

engine-flutter-autoroll mentioned this pull request Dec 15, 2020

Roll Plugins from 7d392476ac20 to f8a53a5f27f3 (12 revisions) flutter/flutter#72367

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Dec 15, 2020

6870b08 Exclude null-safe plugins from testing on stable (flutter/plu…

f685010

…gins#3318)

engine-flutter-autoroll mentioned this pull request Dec 15, 2020

Roll Plugins from 7d392476ac20 to bad9fd1578ad (13 revisions) flutter/flutter#72373

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Dec 15, 2020

6870b08 Exclude null-safe plugins from testing on stable (flutter/plu…

49592b5

…gins#3318)

engine-flutter-autoroll mentioned this pull request Dec 16, 2020

Roll Plugins from 7d392476ac20 to b85d8eb326a6 (14 revisions) flutter/flutter#72417

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Dec 16, 2020

6870b08 Exclude null-safe plugins from testing on stable (flutter/plu…

b327abe

…gins#3318)

engine-flutter-autoroll mentioned this pull request Dec 16, 2020

Roll Plugins from 7d392476ac20 to aa8fcb4b758f (15 revisions) flutter/flutter#72448

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Dec 16, 2020

6870b08 Exclude null-safe plugins from testing on stable (flutter/plu…

f06b8d8

…gins#3318)

engine-flutter-autoroll mentioned this pull request Dec 16, 2020

Roll Plugins from 7d392476ac20 to 5482d9a4cb2d (16 revisions) flutter/flutter#72460

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Dec 16, 2020

6870b08 Exclude null-safe plugins from testing on stable (flutter/plu…

0be877f

…gins#3318)

engine-flutter-autoroll mentioned this pull request Dec 16, 2020

Roll Plugins from 7d392476ac20 to 05879a3a4d8e (17 revisions) flutter/flutter#72465

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Dec 16, 2020

6870b08 Exclude null-safe plugins from testing on stable (flutter/plu…

9edbc85

…gins#3318)

amirh mentioned this pull request Dec 17, 2020

NNBD plugins in flutter/plugins are skipping some tests flutter/flutter#72493

Closed

engine-flutter-autoroll mentioned this pull request Dec 17, 2020

Roll Plugins from 7d392476ac20 to b2e9ca5c5299 (18 revisions) flutter/flutter#72543

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Dec 17, 2020

6870b08 Exclude null-safe plugins from testing on stable (flutter/plu…

0c2692d

…gins#3318)

engine-flutter-autoroll mentioned this pull request Dec 18, 2020

Roll Plugins from 7d392476ac20 to 41b448633350 (19 revisions) flutter/flutter#72567

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Dec 18, 2020

6870b08 Exclude null-safe plugins from testing on stable (flutter/plu…

3b27150

…gins#3318)

engine-flutter-autoroll mentioned this pull request Dec 18, 2020

Roll Plugins from 7d392476ac20 to 73eeb30c9819 (20 revisions) flutter/flutter#72574

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Dec 18, 2020

6870b08 Exclude null-safe plugins from testing on stable (flutter/plu…

b9c48f0

…gins#3318)

engine-flutter-autoroll mentioned this pull request Dec 18, 2020

Roll Plugins from 7d392476ac20 to b6af039a969b (21 revisions) flutter/flutter#72621

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Dec 18, 2020

6870b08 Exclude null-safe plugins from testing on stable (flutter/plu…

dc87974

…gins#3318)

engine-flutter-autoroll mentioned this pull request Dec 18, 2020

Roll Plugins from 7d392476ac20 to b1ab21a63152 (22 revisions) flutter/flutter#72626

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Dec 18, 2020

6870b08 Exclude null-safe plugins from testing on stable (flutter/plu…

f434c2c

…gins#3318)

engine-flutter-autoroll mentioned this pull request Dec 18, 2020

Roll Plugins from 7d392476ac20 to debfbecb53a5 (23 revisions) flutter/flutter#72631

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Dec 18, 2020

6870b08 Exclude null-safe plugins from testing on stable (flutter/plu…

4d80a6d

…gins#3318)

engine-flutter-autoroll mentioned this pull request Dec 19, 2020

Roll Plugins from 7d392476ac20 to 22422af71d79 (24 revisions) flutter/flutter#72644

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Dec 19, 2020

6870b08 Exclude null-safe plugins from testing on stable (flutter/plu…

e6a74d3

…gins#3318)

engine-flutter-autoroll mentioned this pull request Dec 19, 2020

Roll Plugins from 7d392476ac20 to 0c6ed0418bde (25 revisions) flutter/flutter#72647

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Dec 19, 2020

6870b08 Exclude null-safe plugins from testing on stable (flutter/plu…

1eb6913

…gins#3318)

engine-flutter-autoroll mentioned this pull request Dec 19, 2020

Roll Plugins from 7d392476ac20 to b289e1a4fb1b (26 revisions) flutter/flutter#72661

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Dec 19, 2020

6870b08 Exclude null-safe plugins from testing on stable (flutter/plu…

76444c7

…gins#3318)

engine-flutter-autoroll mentioned this pull request Dec 20, 2020

Roll Plugins from 7d392476ac20 to b4466e7c7fea (27 revisions) flutter/flutter#72667

Merged

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Dec 20, 2020

6870b08 Exclude null-safe plugins from testing on stable (flutter/plu…

8b743fa

…gins#3318)

amantoux pushed a commit to amantoux/plugins that referenced this pull request Feb 8, 2021

Exclude null-safe plugins from testing on stable (flutter#3318)

c26866f

adsonpleal pushed a commit to nubank/plugins that referenced this pull request Feb 26, 2021

Exclude null-safe plugins from testing on stable (flutter#3318)

80f2544

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Exclude null-safe plugins from testing on stable #3318

Exclude null-safe plugins from testing on stable #3318

blasten commented Dec 10, 2020 •

edited

Loading

amirh left a comment

amirh Dec 10, 2020

blasten Dec 10, 2020

amirh Dec 10, 2020

blasten Dec 10, 2020

amirh left a comment

Exclude null-safe plugins from testing on stable #3318

Exclude null-safe plugins from testing on stable #3318

Conversation

blasten commented Dec 10, 2020 • edited Loading

amirh left a comment

Choose a reason for hiding this comment

amirh Dec 10, 2020

Choose a reason for hiding this comment

blasten Dec 10, 2020

Choose a reason for hiding this comment

amirh Dec 10, 2020

Choose a reason for hiding this comment

blasten Dec 10, 2020

Choose a reason for hiding this comment

amirh left a comment

Choose a reason for hiding this comment

blasten commented Dec 10, 2020 •

edited

Loading