Skip to content
This repository has been archived by the owner on Feb 22, 2023. It is now read-only.

[camera] Expanded platform interface to support setting flash mode #3313

Merged
merged 4 commits into from
Dec 10, 2020
Merged

[camera] Expanded platform interface to support setting flash mode #3313

merged 4 commits into from
Dec 10, 2020

Conversation

BeMacized
Copy link
Contributor

Description

Adds the required methods necessary to implement flash support to the camera_platform_interface. Once this PR has landed packages implementing the camera_platform_interface will be able to add flash support to the camera implementations.

Related Issues

flutter/flutter#19845

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • My PR includes unit or integration tests for all changed/updated/fixed behaviors (See Contributor Guide).
  • All existing and new tests are passing.
  • I updated/added relevant documentation (doc comments with ///).
  • The analyzer (flutter analyze) does not report any problems on my PR.
  • I read and followed the Flutter Style Guide.
  • The title of the PR starts with the name of the plugin surrounded by square brackets, e.g. [shared_preferences]
  • I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy.
  • I updated CHANGELOG.md to add a description of the change.
  • I signed the CLA.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Does your PR require plugin users to manually update their apps to accommodate your change?

  • Yes, this is a breaking change (please indicate a breaking change in CHANGELOG.md and increment major revision).
  • No, this is not a breaking change.

@google-cla google-cla bot added the cla: yes label Dec 9, 2020
mvanbeusekom
mvanbeusekom approved these changes Dec 9, 2020
View reviewed changes
Copy link
Contributor

@mvanbeusekom mvanbeusekom left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, can be merged when tree goes green

@BeMacized BeMacized changed the title [camera] Expanded platform interface so support setting flash mode [camera] Expanded platform interface to support setting flash mode Dec 9, 2020
ditman
ditman approved these changes Dec 9, 2020
View reviewed changes
Copy link
Member

@ditman ditman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great! And it seems to be implementable in web!

My only recommendation is not to rely on the toString method of the FlashMode Enum, and instead have a translation table from enum -> string. Other than that, ship it!

packages/camera/camera_platform_interface/lib/src/method_channel/method_channel_camera.dart Outdated
'setFlashMode',
<String, dynamic>{
'cameraId': cameraId,
'mode': mode.toString().split('.').last,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd recommend doing a Map<FlashMode, String> to do this conversion, instead of relying on the "toString" representation of the Enum.

mvanbeusekom
mvanbeusekom approved these changes Dec 10, 2020
View reviewed changes
Copy link
Contributor

@mvanbeusekom mvanbeusekom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

mvanbeusekom
mvanbeusekom reviewed Dec 10, 2020
View reviewed changes
packages/camera/camera_platform_interface/lib/src/method_channel/method_channel_camera.dart Outdated
Comment on lines 194 to 203
String _serializeFlashMode(FlashMode flashMode) {
switch (flashMode) {
case FlashMode.off:
return 'off';
case FlashMode.auto:
return 'auto';
case FlashMode.always:
return 'always';
}
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should handle the default case and throw an argument error explaining the supplied value cannot be supported.

mvanbeusekom
mvanbeusekom suggested changes Dec 10, 2020
View reviewed changes
Copy link
Contributor

@mvanbeusekom mvanbeusekom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a comment after flutter analyze failed.

@mvanbeusekom mvanbeusekom merged commit a7c4929 into flutter:master Dec 10, 2020
@mvanbeusekom mvanbeusekom deleted the feature/camera_flash_platform_interface branch December 10, 2020 13:44
@BeMacized BeMacized mentioned this pull request Dec 10, 2020
Merged
13 tasks
amantoux pushed a commit to amantoux/plugins that referenced this pull request Feb 8, 2021
@BeMacized @amantoux
[camera] Expanded platform interface to support setting flash mode (f…
b795dc2 
…lutter#3313)

* Expanded platform interface so support setting flash mode

* Formatted dart code

* Manually serialize flash mode enum rather than relying on stringification.

* Add default to flash mode serialization
adsonpleal pushed a commit to nubank/plugins that referenced this pull request Feb 26, 2021
@BeMacized @adsonpleal
[camera] Expanded platform interface to support setting flash mode (f…
5885927 
…lutter#3313)

* Expanded platform interface so support setting flash mode

* Formatted dart code

* Manually serialize flash mode enum rather than relying on stringification.

* Add default to flash mode serialization
samandmoore added a commit to Betterment/plugins that referenced this pull request Apr 21, 2021
@samandmoore
Merge branch 'upstream-share-final-null-release' into pull-in-upstrea…
85dbace 
…m-changes

* upstream-share-final-null-release: (233 commits)
  [q-w] Update Flutter SDK constraint (flutter#3323)
  [i-p] Update Flutter SDK constraint (flutter#3322)
  [d-g] Update Flutter SDK constraint (flutter#3321)
  [a-c] Update Flutter SDK constraint (flutter#3320)
  [image_picker_platform_interface] Pass Uri to package:http APIs (flutter#3309)
  Exclude null-safe plugins from testing on stable (flutter#3318)
  [documentation] [url_launcher] fix for readme code sample (flutter#3308)
  [camera] Add zoom support to platform interface (flutter#3312)
  update analysis options for nnbd (flutter#3319)
  [camera] Suppress unchecked cast warning in java test (flutter#3316)
  [image_picker] [integration_test] Fixes to make the tree green (flutter#3317)
  [camera] Expanded platform interface to support setting flash mode (flutter#3313)
  [Espresso] Android Code Inspection and Clean up (flutter#3111)
  [camera] Add `camera_platform_interface` package (flutter#3253)
  [camera] Support Android 30 (flutter#3299)
  bump integration test to 1.0.0 (flutter#3295)
  [android_alarm_manager] fix AndroidManifest.xml for android lint issue "XML tag has empty body" (flutter#3288)
  Use testWidgets instead of test to fix failures not surfacing on CI (flutter#3279)
  [file_selector_platform_interface] Migrate to cross_file package (flutter#3286)
  Fix broken link (flutter#3280)
  ...
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mvanbeusekom mvanbeusekom mvanbeusekom approved these changes

@ditman ditman ditman approved these changes

@bparrishMines bparrishMines Awaiting requested review from bparrishMines

Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@BeMacized @ditman @mvanbeusekom