Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[in_app_purchase_platform_interface] Adds countryCode API #6548

Merged
merged 2 commits into from
Apr 17, 2024
Merged

[in_app_purchase_platform_interface] Adds countryCode API #6548

merged 2 commits into from
Apr 17, 2024

Conversation

reidbaker
Copy link
Contributor

@reidbaker reidbaker commented Apr 16, 2024 •
edited
Loading

Original pr #6540

Related to flutter/flutter#141627

Pre-launch Checklist

  • I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • I read the [Tree Hygiene] wiki page, which explains my responsibilities.
  • I read and followed the [relevant style guides] and ran the auto-formatter. (Unlike the flutter/flutter repo, the flutter/packages repo does use dart format.)
  • I signed the [CLA].
  • The title of the PR starts with the name of the package surrounded by square brackets, e.g. [shared_preferences]
  • I [linked to at least one issue that this PR fixes] in the description above.
  • I updated pubspec.yaml with an appropriate new version according to the [pub versioning philosophy], or this PR is [exempt from version changes].
  • I updated CHANGELOG.md to add a description of the change, [following repository CHANGELOG style].
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is [test-exempt].
  • All existing and new tests are passing.

@reidbaker reidbaker marked this pull request as ready for review April 16, 2024 18:51
LouiseHsu
LouiseHsu approved these changes Apr 16, 2024
View reviewed changes
Copy link
Contributor

@LouiseHsu LouiseHsu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

stuartmorgan
stuartmorgan approved these changes Apr 16, 2024
View reviewed changes
Copy link
Contributor

@stuartmorgan stuartmorgan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Usually we try to avoid documenting platform-specific behavior in the app-facing package for scalability and separation of concerns, but it seems like we probably can't provide much useful documentation here without it.

@reidbaker
Copy link
Contributor Author

LGTM. Usually we try to avoid documenting platform-specific behavior in the app-facing package for scalability and separation of concerns, but it seems like we probably can't provide much useful documentation here without it.

FWIW I agree I debated just linking to the underlying documentation but thought it would be easier for customers to just see the content where they were looking. If we decided we wanted to convert the underlying country codes into some standard then enforce it ourselves we could avoid the platform specific references but I think that most of the time the answer will either be the same or values will get passed to a system that assumes the platform implementation.

@reidbaker reidbaker added the autosubmit Merge PR when tree becomes green via auto submit App label Apr 16, 2024
@auto-submit auto-submit bot merged commit 0dd8de2 into main Apr 17, 2024
78 checks passed
@auto-submit auto-submit bot deleted the i141627-country-code-interface-only branch April 17, 2024 15:28
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 18, 2024
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Apr 18, 2024
@engine-flutter-autoroll
0dd8de2 [in_app_purchase_platform_interface] Adds countryCode API (fl…
59a4aaf 
…utter/packages#6548)
auto-submit bot pushed a commit to flutter/flutter that referenced this pull request Apr 18, 2024
@engine-flutter-autoroll
Roll Packages from d39830e to 0e3809d (9 revisions) (#146992)
af06493 
flutter/packages@d39830e...0e3809d

2024-04-18 49699333+dependabot[bot]@users.noreply.github.com Bump github/codeql-action from 3.25.0 to 3.25.1 (flutter/packages#6562)
2024-04-18 [email protected] [ci] Add Linux desktop support to Linux custom_package_tests (flutter/packages#6551)
2024-04-17 [email protected] [two_dimensional_scrollables] Refactor Spans for common use (flutter/packages#6550)
2024-04-17 [email protected] [in_app_purchase] Add api to expose country code (flutter/packages#6540)
2024-04-17 [email protected] [camera] Initial iOS Pigeon conversion (flutter/packages#6553)
2024-04-17 [email protected] [in_app_purchase] Add countryCode implementation to android and storekit (flutter/packages#6556)
2024-04-17 [email protected] [google_sign_in_ios] Upgrade GoogleSignIn iOS SDK to 7.1 (flutter/packages#6404)
2024-04-17 [email protected] [in_app_purchase_platform_interface] Adds countryCode API (flutter/packages#6548)
2024-04-17 [email protected] [google_maps_flutter] Update app-facing package iOS requirements (flutter/packages#6552)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
gilnobrega pushed a commit to gilnobrega/flutter that referenced this pull request Apr 22, 2024
@engine-flutter-autoroll @gilnobrega
Roll Packages from d39830e to 0e3809d (9 revisions) (flutter#146992)
2d5fb1e 
flutter/packages@d39830e...0e3809d

2024-04-18 49699333+dependabot[bot]@users.noreply.github.com Bump github/codeql-action from 3.25.0 to 3.25.1 (flutter/packages#6562)
2024-04-18 [email protected] [ci] Add Linux desktop support to Linux custom_package_tests (flutter/packages#6551)
2024-04-17 [email protected] [two_dimensional_scrollables] Refactor Spans for common use (flutter/packages#6550)
2024-04-17 [email protected] [in_app_purchase] Add api to expose country code (flutter/packages#6540)
2024-04-17 [email protected] [camera] Initial iOS Pigeon conversion (flutter/packages#6553)
2024-04-17 [email protected] [in_app_purchase] Add countryCode implementation to android and storekit (flutter/packages#6556)
2024-04-17 [email protected] [google_sign_in_ios] Upgrade GoogleSignIn iOS SDK to 7.1 (flutter/packages#6404)
2024-04-17 [email protected] [in_app_purchase_platform_interface] Adds countryCode API (flutter/packages#6548)
2024-04-17 [email protected] [google_maps_flutter] Update app-facing package iOS requirements (flutter/packages#6552)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
TecHaxter pushed a commit to TecHaxter/flutter_packages that referenced this pull request May 22, 2024
@reidbaker @TecHaxter
[in_app_purchase_platform_interface] Adds countryCode API (flutter#6548)
0dfcfbc 
Original pr flutter#6540

Related to flutter/flutter#141627
arc-yong pushed a commit to Arctuition/packages-arc that referenced this pull request Jun 14, 2024
@reidbaker @arc-yong
[in_app_purchase_platform_interface] Adds countryCode API (flutter#6548)
894d10a 
Original pr flutter#6540

Related to flutter/flutter#141627
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LouiseHsu LouiseHsu LouiseHsu approved these changes

@gmackall gmackall gmackall approved these changes

@stuartmorgan stuartmorgan stuartmorgan approved these changes

@bparrishMines bparrishMines Awaiting requested review from bparrishMines bparrishMines is a code owner

Assignees
No one assigned
Labels
autosubmit Merge PR when tree becomes green via auto submit App p: in_app_purchase
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@reidbaker @stuartmorgan @gmackall @LouiseHsu