Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[in_app_purchase] Add api to expose country code #6540

Merged
merged 20 commits into from
Apr 17, 2024
Merged

[in_app_purchase] Add api to expose country code #6540

merged 20 commits into from
Apr 17, 2024

Conversation

reidbaker
Copy link
Contributor

@reidbaker reidbaker commented Apr 15, 2024 •
edited
Loading

  • Add changelog and version bump
  • dependency override from package tool

Fixes flutter/flutter/issues/141627

Pre-launch Checklist

  • I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • I read the [Tree Hygiene] wiki page, which explains my responsibilities.
  • I read and followed the [relevant style guides] and ran the auto-formatter. (Unlike the flutter/flutter repo, the flutter/packages repo does use dart format.)
  • I signed the [CLA].
  • The title of the PR starts with the name of the package surrounded by square brackets, e.g. [shared_preferences]
  • I [linked to at least one issue that this PR fixes] in the description above.
  • I updated pubspec.yaml with an appropriate new version according to the [pub versioning philosophy], or this PR is [exempt from version changes].
  • I updated CHANGELOG.md to add a description of the change, [following repository CHANGELOG style].
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is [test-exempt].
  • All existing and new tests are passing.

@reidbaker reidbaker marked this pull request as ready for review April 15, 2024 19:06
LouiseHsu
LouiseHsu approved these changes Apr 15, 2024
View reviewed changes
Copy link
Contributor

@LouiseHsu LouiseHsu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ios side lgtm! thanks for adding the ios implementation too!

gmackall
gmackall approved these changes Apr 16, 2024
View reviewed changes
Copy link
Member

@gmackall gmackall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Android LGTM! Just some nitpicky docs comments

packages/in_app_purchase/in_app_purchase/lib/in_app_purchase.dart Outdated Show resolved Hide resolved
packages/in_app_purchase/in_app_purchase_platform_interface/CHANGELOG.md Outdated Show resolved Hide resolved
...ges/in_app_purchase/in_app_purchase_platform_interface/lib/src/in_app_purchase_platform.dart Outdated Show resolved Hide resolved
stuartmorgan
stuartmorgan reviewed Apr 16, 2024
View reviewed changes
Copy link
Contributor

@stuartmorgan stuartmorgan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor comments, but this looks good to split out the first PR (with just the platform interface part).

packages/in_app_purchase/in_app_purchase/lib/in_app_purchase.dart Outdated
///
///
Future<void> countryCode() =>
throw UnimplementedError('countryCode() has not been implemented.');
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't this be calling the new platform interface method?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And you'll want to add Dart unit tests at this layer that it is in fact calling through.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done! Thanks for the out of band explanation of this packages value.

packages/in_app_purchase/in_app_purchase/pubspec.yaml Outdated
@@ -2,7 +2,7 @@ name: in_app_purchase
description: A Flutter plugin for in-app purchases. Exposes APIs for making in-app purchases through the App Store and Google Play.
repository: https://github.com/flutter/packages/tree/main/packages/in_app_purchase/in_app_purchase
issue_tracker: https://github.com/flutter/flutter/issues?q=is%3Aissue+is%3Aopen+label%3A%22p%3A+in_app_purchase%22
version: 3.1.13
version: 3.2.0

environment:
sdk: ^3.1.0
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FYI these values will need to be updated to match i_a_p_storekit's lower limits when you do the final app-facing PR, otherwise pub get will fail.

packages/in_app_purchase/in_app_purchase_platform_interface/CHANGELOG.md Outdated Show resolved Hide resolved
...ges/in_app_purchase/in_app_purchase_platform_interface/lib/src/in_app_purchase_platform.dart Outdated Show resolved Hide resolved
@reidbaker
Add default implementation, update in_app_purchase/in_app_purchase to…
912ab08 
… have a test in addition to in_app_purchase_interface
@reidbaker reidbaker mentioned this pull request Apr 16, 2024
Merged
11 tasks
auto-submit bot pushed a commit that referenced this pull request Apr 17, 2024
@reidbaker
[in_app_purchase_platform_interface] Adds countryCode API (#6548)
0dd8de2 
Original pr #6540

Related to flutter/flutter#141627
@reidbaker reidbaker mentioned this pull request Apr 17, 2024
Merged
11 tasks
auto-submit bot pushed a commit that referenced this pull request Apr 17, 2024
@reidbaker
[in_app_purchase] Add countryCode implementation to android and store…
87ae14f 
…kit (#6556)

Part of flutter/flutter/issues/141627
reviewed pr #6540
@reidbaker
Copy link
Contributor Author

Assuming the tests pass this pr is ready to land.

LouiseHsu
LouiseHsu approved these changes Apr 17, 2024
View reviewed changes
Copy link
Contributor

@LouiseHsu LouiseHsu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@reidbaker reidbaker added the override: no versioning needed Override the check requiring version bumps for most changes label Apr 17, 2024
@reidbaker

This comment was marked as outdated.

Sign in to view
@reidbaker reidbaker removed the override: no versioning needed Override the check requiring version bumps for most changes label Apr 17, 2024
@reidbaker reidbaker added the autosubmit Merge PR when tree becomes green via auto submit App label Apr 17, 2024
@auto-submit auto-submit bot merged commit 3f4c0f5 into flutter:main Apr 17, 2024
78 checks passed
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 18, 2024
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Apr 18, 2024
@engine-flutter-autoroll
3f4c0f5 [in_app_purchase] Add api to expose country code (flutter/pac…
ab879de 
…kages#6540)
auto-submit bot pushed a commit to flutter/flutter that referenced this pull request Apr 18, 2024
@engine-flutter-autoroll
Roll Packages from d39830e to 0e3809d (9 revisions) (#146992)
af06493 
flutter/packages@d39830e...0e3809d

2024-04-18 49699333+dependabot[bot]@users.noreply.github.com Bump github/codeql-action from 3.25.0 to 3.25.1 (flutter/packages#6562)
2024-04-18 [email protected] [ci] Add Linux desktop support to Linux custom_package_tests (flutter/packages#6551)
2024-04-17 [email protected] [two_dimensional_scrollables] Refactor Spans for common use (flutter/packages#6550)
2024-04-17 [email protected] [in_app_purchase] Add api to expose country code (flutter/packages#6540)
2024-04-17 [email protected] [camera] Initial iOS Pigeon conversion (flutter/packages#6553)
2024-04-17 [email protected] [in_app_purchase] Add countryCode implementation to android and storekit (flutter/packages#6556)
2024-04-17 [email protected] [google_sign_in_ios] Upgrade GoogleSignIn iOS SDK to 7.1 (flutter/packages#6404)
2024-04-17 [email protected] [in_app_purchase_platform_interface] Adds countryCode API (flutter/packages#6548)
2024-04-17 [email protected] [google_maps_flutter] Update app-facing package iOS requirements (flutter/packages#6552)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
@vmeretin vmeretin mentioned this pull request Apr 19, 2024
Closed
11 tasks
@reidbaker reidbaker deleted the i141627-country-code-api-top-line branch April 19, 2024 15:28
gilnobrega pushed a commit to gilnobrega/flutter that referenced this pull request Apr 22, 2024
@engine-flutter-autoroll @gilnobrega
Roll Packages from d39830e to 0e3809d (9 revisions) (flutter#146992)
2d5fb1e 
flutter/packages@d39830e...0e3809d

2024-04-18 49699333+dependabot[bot]@users.noreply.github.com Bump github/codeql-action from 3.25.0 to 3.25.1 (flutter/packages#6562)
2024-04-18 [email protected] [ci] Add Linux desktop support to Linux custom_package_tests (flutter/packages#6551)
2024-04-17 [email protected] [two_dimensional_scrollables] Refactor Spans for common use (flutter/packages#6550)
2024-04-17 [email protected] [in_app_purchase] Add api to expose country code (flutter/packages#6540)
2024-04-17 [email protected] [camera] Initial iOS Pigeon conversion (flutter/packages#6553)
2024-04-17 [email protected] [in_app_purchase] Add countryCode implementation to android and storekit (flutter/packages#6556)
2024-04-17 [email protected] [google_sign_in_ios] Upgrade GoogleSignIn iOS SDK to 7.1 (flutter/packages#6404)
2024-04-17 [email protected] [in_app_purchase_platform_interface] Adds countryCode API (flutter/packages#6548)
2024-04-17 [email protected] [google_maps_flutter] Update app-facing package iOS requirements (flutter/packages#6552)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
@darshankawar darshankawar mentioned this pull request Apr 23, 2024
Closed
TecHaxter pushed a commit to TecHaxter/flutter_packages that referenced this pull request May 22, 2024
@reidbaker @TecHaxter
[in_app_purchase_platform_interface] Adds countryCode API (flutter#6548)
0dfcfbc 
Original pr flutter#6540

Related to flutter/flutter#141627
TecHaxter pushed a commit to TecHaxter/flutter_packages that referenced this pull request May 22, 2024
@reidbaker @TecHaxter
[in_app_purchase] Add countryCode implementation to android and store…
d817df4 
…kit (flutter#6556)

Part of flutter/flutter/issues/141627
reviewed pr flutter#6540
TecHaxter pushed a commit to TecHaxter/flutter_packages that referenced this pull request May 22, 2024
@reidbaker @TecHaxter
[in_app_purchase] Add api to expose country code (flutter#6540)
8636ace 
- **Add changelog and version bump**
- **dependency override from package tool**

Fixes flutter/flutter/issues/141627
arc-yong pushed a commit to Arctuition/packages-arc that referenced this pull request Jun 14, 2024
@reidbaker @arc-yong
[in_app_purchase_platform_interface] Adds countryCode API (flutter#6548)
894d10a 
Original pr flutter#6540

Related to flutter/flutter#141627
arc-yong pushed a commit to Arctuition/packages-arc that referenced this pull request Jun 14, 2024
@reidbaker @arc-yong
[in_app_purchase] Add countryCode implementation to android and store…
52a4dd8 
…kit (flutter#6556)

Part of flutter/flutter/issues/141627
reviewed pr flutter#6540
arc-yong pushed a commit to Arctuition/packages-arc that referenced this pull request Jun 14, 2024
@reidbaker @arc-yong
[in_app_purchase] Add api to expose country code (flutter#6540)
6944cc0 
- **Add changelog and version bump**
- **dependency override from package tool**

Fixes flutter/flutter/issues/141627
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LouiseHsu LouiseHsu LouiseHsu approved these changes

@stuartmorgan stuartmorgan stuartmorgan approved these changes

@bparrishMines bparrishMines Awaiting requested review from bparrishMines bparrishMines is a code owner

@gmackall gmackall Awaiting requested review from gmackall

Assignees
No one assigned
Labels
autosubmit Merge PR when tree becomes green via auto submit App p: in_app_purchase
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[in_app_purchase] Feature Request: add store's countryCode to API
4 participants
@reidbaker @stuartmorgan @gmackall @LouiseHsu