[video_player] Darwin implementation cleanup #6507
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hellohuanlin
approved these changes
Apr 12, 2024
| return result; | ||
| - (nullable NSNumber *)positionForPlayer:(NSInteger)textureId error:(FlutterError **)error { | ||
| FVPVideoPlayer *player = self.playersByTextureId[@(textureId)]; | ||
| return @([player position]); |
There was a problem hiding this comment.
should this be return player ? @([player position]) : nil given the nullable return type?
There was a problem hiding this comment.
stuartmorgan
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Apr 15, 2024
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Apr 15, 2024
flutter/packages@78f684c...6698b2d 2024-04-14 [email protected] Fix error in markdown parsing image dimensions (flutter/packages#6518) 2024-04-12 [email protected] [Many] Bump to min minSdkVersion of 19 across all plugins (flutter/packages#6506) 2024-04-12 [email protected] [video_player] Darwin implementation cleanup (flutter/packages#6507) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
gilnobrega
pushed a commit
to gilnobrega/flutter
that referenced
this pull request
Apr 22, 2024
flutter/packages@78f684c...6698b2d 2024-04-14 [email protected] Fix error in markdown parsing image dimensions (flutter/packages#6518) 2024-04-12 [email protected] [Many] Bump to min minSdkVersion of 19 across all plugins (flutter/packages#6506) 2024-04-12 [email protected] [video_player] Darwin implementation cleanup (flutter/packages#6507) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
TecHaxter
pushed a commit
to TecHaxter/flutter_packages
that referenced
this pull request
May 22, 2024
Does some cleanup/improvements to the iOS/macOS implementation in preparation for future work: - Modernizes the Pigeon API. The current version dates from when methods could only take and return a single class object, so had wrapper classes for everything that are no longer needed. - Removes unnecessary branching for iOS and macOS by enabling the new frame checking logic for iOS. This was only there to avoid coupling iOS behavioral changes to enabling initial macOS support. - Removes an async workaround that says it's for a race that was fixed in the engine a long time ago (far longer than our oldest supported Flutter version). - Resolves a TODO about unregistering at engine shutdown, as it's been supported on `stable` for quite a while now. Fixes flutter/flutter#138427
arc-yong
pushed a commit
to Arctuition/packages-arc
that referenced
this pull request
Jun 14, 2024
Does some cleanup/improvements to the iOS/macOS implementation in preparation for future work: - Modernizes the Pigeon API. The current version dates from when methods could only take and return a single class object, so had wrapper classes for everything that are no longer needed. - Removes unnecessary branching for iOS and macOS by enabling the new frame checking logic for iOS. This was only there to avoid coupling iOS behavioral changes to enabling initial macOS support. - Removes an async workaround that says it's for a race that was fixed in the engine a long time ago (far longer than our oldest supported Flutter version). - Resolves a TODO about unregistering at engine shutdown, as it's been supported on `stable` for quite a while now. Fixes flutter/flutter#138427
11 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Does some cleanup/improvements to the iOS/macOS implementation in preparation for future work:
stablefor quite a while now.Fixes flutter/flutter#138427
Pre-launch Checklist
dart format.)[shared_preferences]pubspec.yamlwith an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.CHANGELOG.mdto add a description of the change, following repository CHANGELOG style.///).If you need help, consider asking for advice on the #hackers-new channel on Discord.