[Many] Bump to min minSdkVersion of 19 across all plugins #6506
Conversation
gmackall
requested review from
camsim99,
reidbaker and
tarrinneal
as code owners
What's the Flutter version that has that change? We need to make sure none of the packages being changed here have a min Flutter SDK version lower than that. |
If I had to pick a specific PR, it would be flutter/flutter#129729, though the change that really matters is the change to https://docs.flutter.dev/reference/supported-platforms, which isn't versioned along with the Flutter SDK really. But flutter/flutter#129729 is in 3.16 at the earliest, so it sounds like this will need to wait until the next stable, at which the minimum allowed will be N-2=3.16 (according to https://github.com/flutter/flutter/wiki/Updating-Packages-repo-for-a-stable-release)? |
For the purposes of the packages repo it is the PR that matters, not the policy on a wiki. The goal here is to make package changes in a way that does not suddenly break people's ability to compile their app when getting minor or bugfix version updates to the packages they use. Actively breaking people with non-breaking-version plugin changes and then pointing them to a wiki page they had no reason to look at if they file a bug would be a bad user experience. Automatically getting the last working version is a much better experience. So when changing minimum OS versions the goal is to make is such that the
Packages aren't required to support N-2, they just aren't allowed to support anything older; only supporting back to current |
packages/espresso/pubspec.yaml
Outdated
| @@ -3,7 +3,7 @@ description: Java classes for testing Flutter apps using Espresso. | |||
| Allows driving Flutter widgets from a native Espresso test. | |||
| repository: https://github.com/flutter/packages/tree/main/packages/espresso | |||
| issue_tracker: https://github.com/flutter/flutter/issues?q=is%3Aissue+is%3Aopen+label%3A%22p%3A+espresso%22 | |||
| version: 0.3.0+7 | |||
| version: 0.3.0+8 | |||
|
|
|||
| environment: | |||
| sdk: ^3.1.0 | |||
There was a problem hiding this comment.
Based on the discussion in comments, every package being touched here that still lists Flutter 3.13 support needs to be changed to 3.16 instead.
|
The Dart min SDK version needs to be consistent; you may want to use the |
|
I ended up making the change by hand - the script made changes to every package, I believe because I had changed the legacy test. |
|
Ah, yes. I get bitten by that occasionally with the version bump script; I need to make a new flag that is only for these local tool usages. |
gmackall
added
the
autosubmit
#6506 was supposed to update everything to 19+, but missed local_auth_android. PRs are now failing lint in this package because the example is trying to build with 16 but dependencies use 19.
flutter/packages@78f684c...6698b2d 2024-04-14 [email protected] Fix error in markdown parsing image dimensions (flutter/packages#6518) 2024-04-12 [email protected] [Many] Bump to min minSdkVersion of 19 across all plugins (flutter/packages#6506) 2024-04-12 [email protected] [video_player] Darwin implementation cleanup (flutter/packages#6507) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
#6506 was supposed to update everything to 19+, but missed local_auth_android. This updates it to require 19 as well.
flutter/packages@78f684c...6698b2d 2024-04-14 [email protected] Fix error in markdown parsing image dimensions (flutter/packages#6518) 2024-04-12 [email protected] [Many] Bump to min minSdkVersion of 19 across all plugins (flutter/packages#6506) 2024-04-12 [email protected] [video_player] Darwin implementation cleanup (flutter/packages#6507) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
* Bumps any `minSdkVersion`'s below 19 to 19, as the change to only support 19+ has been in stable for a bit now. * Bumps the minimum required flutter version to 3.16 for the changed packages, as that is the first version in which we started automigrating `minSdkVersion`'s less than 19. * Also bumps the `minSdkVersion` in the legacy project to `flutter.minSdkVersion`, as this would happen when running an app with `minSdkVersion` < 19. * Removes some code branches for cases of sdk < 19. * Fixes some failing tests in `video_player` - for full transparency, I have now idea how these could have been passing before?
flutter#6506 was supposed to update everything to 19+, but missed local_auth_android. This updates it to require 19 as well.
* Bumps any `minSdkVersion`'s below 19 to 19, as the change to only support 19+ has been in stable for a bit now. * Bumps the minimum required flutter version to 3.16 for the changed packages, as that is the first version in which we started automigrating `minSdkVersion`'s less than 19. * Also bumps the `minSdkVersion` in the legacy project to `flutter.minSdkVersion`, as this would happen when running an app with `minSdkVersion` < 19. * Removes some code branches for cases of sdk < 19. * Fixes some failing tests in `video_player` - for full transparency, I have now idea how these could have been passing before?
flutter#6506 was supposed to update everything to 19+, but missed local_auth_android. This updates it to require 19 as well.
minSdkVersion's below 19 to 19, as the change to only support 19+ has been in stable for a bit now.minSdkVersion's less than 19.minSdkVersionin the legacy project toflutter.minSdkVersion, as this would happen when running an app withminSdkVersion< 19.video_player- for full transparency, I have now idea how these could have been passing before?Pre-launch Checklist
dart format.)[shared_preferences]pubspec.yamlwith an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.CHANGELOG.mdto add a description of the change, following repository CHANGELOG style.///).If you need help, consider asking for advice on the #hackers-new channel on Discord.