Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix per SDK Stream<Uint8List> breaking changes #3640

Merged
merged 1 commit into from
Jul 5, 2019
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion tool/grind.dart
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@ colors() async {
// Get color file from flutter.
HttpClientRequest request = await new HttpClient().getUrl(Uri.parse(kUrl));
HttpClientResponse response = await request.close();
List<String> data = await response.transform(utf8.decoder).toList();
List<String> data = await utf8.decoder.bind(response).toList();

// Remove an import and define the Color class.
String str = data.join('');
Expand Down
2 changes: 1 addition & 1 deletion tool/icons/update_icons.dart
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ void main() async {
Future<String> downloadUrl(String url) async {
HttpClientRequest request = await new HttpClient().getUrl(Uri.parse(url));
HttpClientResponse response = await request.close();
List<String> data = await response.transform(utf8.decoder).toList();
List<String> data = await utf8.decoder.bind(response).toList();
return data.join('');
}

Expand Down
5 changes: 2 additions & 3 deletions tool/plugin/lib/plugin.dart
Original file line number Diff line number Diff line change
Expand Up @@ -131,9 +131,8 @@ Future<File> genPluginXml(BuildSpec spec, String destDir, String path) async {
dest.writeln(
"<!-- Do not edit; instead, modify ${p.basename(templatePath)}, and run './bin/plugin generate'. -->");
dest.writeln();
await new File(p.join(rootPath, 'resources', templatePath))
.openRead()
.transform(utf8.decoder)
await utf8.decoder
.bind(new File(p.join(rootPath, 'resources', templatePath)).openRead())
.transform(new LineSplitter())
.forEach((l) => dest.writeln(substituteTemplateVariables(l, spec)));
await dest.close();
Expand Down