Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix per SDK Stream<Uint8List> breaking changes #3640

Merged
merged 1 commit into from
Jul 5, 2019

Conversation

tvolkert
Copy link
Contributor

@tvolkert tvolkert commented Jul 3, 2019

This updates call sites with forward-compatible fixes for
a recent Dart SDK change that changed the following APIs
to be Stream<Uint8List> rather than Stream<List<int>>:

  • HttpClientResponse
  • File.openRead()

dart-lang/sdk#36900

Copy link
Member

@devoncarew devoncarew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! Looks like there's a travis failure related to an unused import:

https://travis-ci.org/flutter/flutter-intellij/jobs/553981616#L634

This updates call sites with forward-compatible fixes for
a recent Dart SDK change that changed the following APIs
to be `Stream<Uint8List>` rather than `Stream<List<int>>`:

* HttpClientResponse
* File.openRead()

dart-lang/sdk#36900
@tvolkert
Copy link
Contributor Author

tvolkert commented Jul 4, 2019

Fixed

Copy link
Member

@devoncarew devoncarew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 thanks!

@devoncarew devoncarew merged commit 15ef3fd into flutter:master Jul 5, 2019
alexander-doroshko pushed a commit to alexander-doroshko/flutter-intellij that referenced this pull request Jan 24, 2020
This updates call sites with forward-compatible fixes for
a recent Dart SDK change that changed the following APIs
to be `Stream<Uint8List>` rather than `Stream<List<int>>`:

* HttpClientResponse
* File.openRead()

dart-lang/sdk#36900
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants