Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix permissions on macos artifacts #45598

Merged
merged 7 commits into from
Sep 14, 2023
Merged

Fix permissions on macos artifacts #45598

Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
771d4e6
Set read and execute for all in versions folder.
godofredoc Sep 8, 2023
8b1029d
Fix variable name.
godofredoc Sep 9, 2023
f91c10a
Change permissions only until all files have been generated.
godofredoc Sep 11, 2023
373396f
Apply execute permissions only to files that are already executable.
godofredoc Sep 11, 2023
6b617b4
Use versions path consistently.
godofredoc Sep 13, 2023
fa26d32
Use single quotes consistently.
godofredoc Sep 13, 2023
cc02b6b
Process permissions before zipping.
godofredoc Sep 14, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 16 additions & 0 deletions sky/tools/create_macos_framework.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,6 +81,7 @@ def main():

shutil.rmtree(fat_framework, True)
shutil.copytree(arm64_framework, fat_framework, symlinks=True)

regenerate_symlinks(fat_framework)

fat_framework_binary = os.path.join(
Expand All @@ -91,6 +92,21 @@ def main():
subprocess.check_call([
'lipo', arm64_dylib, x64_dylib, '-create', '-output', fat_framework_binary
])

# Add group and other readability to all files.
versions_path = os.path.join(fat_framework, 'Versions')
subprocess.check_call(['chmod', '-R', 'og+r', versions_path])
# Find all the files below the target dir with owner execute permission
find_subprocess = subprocess.Popen([
'find', versions_path, '-perm', '-100', '-print0'
],
stdout=subprocess.PIPE)
# Add execute permission for other and group for all files that had it for owner.
xargs_subprocess = subprocess.Popen(['xargs', '-0', 'chmod', 'og+x'],
stdin=find_subprocess.stdout)
find_subprocess.wait()
xargs_subprocess.wait()

process_framework(dst, args, fat_framework, fat_framework_binary)

return 0
Expand Down