Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix permissions on macos artifacts #45598

Merged
merged 7 commits into from
Sep 14, 2023
Merged

Fix permissions on macos artifacts #45598

merged 7 commits into from
Sep 14, 2023

Conversation

godofredoc
Copy link
Contributor

@godofredoc godofredoc commented Sep 8, 2023 •
edited
Loading

Makes mac framework readable and executable by all.

Bug: flutter/flutter#132725

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide and the C++, Objective-C, Java style guides.
  • I listed at least one issue that this PR fixes in the description above.
  • I added new tests to check the change I am making or feature I am adding, or the PR is test-exempt. See testing the engine for instructions on writing and running engine tests.
  • I updated/added relevant documentation (doc comments with ///).
  • I signed the CLA.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@godofredoc godofredoc closed this Sep 8, 2023
@godofredoc godofredoc reopened this Sep 9, 2023
gspencergoog
gspencergoog approved these changes Sep 13, 2023
View reviewed changes
Copy link
Contributor

@gspencergoog gspencergoog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

32384589-a60f0e74-c078-11e7-9bc1-e5b5287aea9d

@godofredoc godofredoc added the autosubmit Merge PR when tree becomes green via auto submit App label Sep 14, 2023
@auto-submit auto-submit bot merged commit 0cf5971 into flutter:main Sep 14, 2023
26 checks passed
@nilsreichardt nilsreichardt mentioned this pull request Sep 14, 2023
Closed
2 tasks
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 14, 2023
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Sep 14, 2023
@engine-flutter-autoroll
0cf597143 Fix script (flutter/engine#45598)
cb4b97e
auto-submit bot pushed a commit to flutter/flutter that referenced this pull request Sep 14, 2023
@engine-flutter-autoroll
Roll Flutter Engine from 4160ebacdae2 to 2cd34d23c1a2 (18 revisions) (#…
d2ff241 
…134749)

flutter/engine@4160eba...2cd34d2

2023-09-14 [email protected] Roll Skia from 91d5a781ebaf to 54253f58533d (2 revisions) (flutter/engine#45829)
2023-09-14 [email protected] Roll Skia from 08fb9768d1b8 to 91d5a781ebaf (3 revisions) (flutter/engine#45828)
2023-09-14 [email protected] Roll Fuchsia Mac SDK from f4jtyOMeNSKGqqI4y... to FF4r9-tqhioBbRG9f... (flutter/engine#45827)
2023-09-14 [email protected] Roll Skia from 45ba26fae9cd to 08fb9768d1b8 (2 revisions) (flutter/engine#45825)
2023-09-14 [email protected] Fix script (flutter/engine#45598)
2023-09-14 [email protected] Roll Fuchsia Linux SDK from 5aKvHj_QcSHJkbWjr... to MzLcTzBiWJ7o3Q2_Z... (flutter/engine#45823)
2023-09-14 [email protected] Roll Skia from 4bb29f80ed43 to 45ba26fae9cd (1 revision) (flutter/engine#45821)
2023-09-14 49699333+dependabot[bot]@users.noreply.github.com Bump html from 0.15.0 to 0.15.4 in /lib/web_ui (flutter/engine#45819)
2023-09-14 [email protected] Roll Skia from 5ff47ea11c13 to 4bb29f80ed43 (1 revision) (flutter/engine#45818)
2023-09-14 [email protected] Roll Skia from 5f18d2ead8c8 to 5ff47ea11c13 (1 revision) (flutter/engine#45815)
2023-09-14 [email protected] Roll Skia from b2a4969c7782 to 5f18d2ead8c8 (2 revisions) (flutter/engine#45814)
2023-09-14 [email protected] Roll Fuchsia Mac SDK from gHhOd3d6V3Zv6CzK2... to f4jtyOMeNSKGqqI4y... (flutter/engine#45813)
2023-09-14 [email protected] Roll Skia from ad51509c8e3f to b2a4969c7782 (3 revisions) (flutter/engine#45812)
2023-09-14 [email protected] Roll Fuchsia Linux SDK from ftcEc93bjtc0q2a6s... to 5aKvHj_QcSHJkbWjr... (flutter/engine#45808)
2023-09-14 49699333+dependabot[bot]@users.noreply.github.com Bump uuid from 3.0.6 to 4.0.0 in /lib/web_ui (flutter/engine#45794)
2023-09-13 [email protected] Roll Skia from 5c7d604c81b0 to ad51509c8e3f (1 revision) (flutter/engine#45802)
2023-09-13 [email protected] Compile a platform dill for dart2wasm (flutter/engine#45797)
2023-09-13 [email protected] Roll Skia from a30fbf83f2e9 to 5c7d604c81b0 (2 revisions) (flutter/engine#45800)

Also rolling transitive DEPS:
  fuchsia/sdk/core/linux-amd64 from ftcEc93bjtc0 to MzLcTzBiWJ7o
  fuchsia/sdk/core/mac-amd64 from gHhOd3d6V3Zv to FF4r9-tqhioB

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
@godofredoc godofredoc changed the title Fix script Fix permissions on macos artifacts Sep 14, 2023
@godofredoc godofredoc deleted the fix_script branch September 14, 2023 19:00
auto-submit bot pushed a commit that referenced this pull request Sep 14, 2023
@godofredoc
CP: Fix permissions on macos artifacts (#45598) (#45844)
bd986c5 
CP: 0cf5971

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
auto-submit bot pushed a commit that referenced this pull request Sep 15, 2023
@godofredoc
CP: Fix permissions on macos artifacts (#45598) (#45900)
453411b 
CP: 0cf5971

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
Mairramer pushed a commit to Mairramer/flutter that referenced this pull request Oct 10, 2023
@engine-flutter-autoroll @Mairramer
Roll Flutter Engine from 4160ebacdae2 to 2cd34d23c1a2 (18 revisions) (f…
99a120c 
…lutter#134749)

flutter/engine@4160eba...2cd34d2

2023-09-14 [email protected] Roll Skia from 91d5a781ebaf to 54253f58533d (2 revisions) (flutter/engine#45829)
2023-09-14 [email protected] Roll Skia from 08fb9768d1b8 to 91d5a781ebaf (3 revisions) (flutter/engine#45828)
2023-09-14 [email protected] Roll Fuchsia Mac SDK from f4jtyOMeNSKGqqI4y... to FF4r9-tqhioBbRG9f... (flutter/engine#45827)
2023-09-14 [email protected] Roll Skia from 45ba26fae9cd to 08fb9768d1b8 (2 revisions) (flutter/engine#45825)
2023-09-14 [email protected] Fix script (flutter/engine#45598)
2023-09-14 [email protected] Roll Fuchsia Linux SDK from 5aKvHj_QcSHJkbWjr... to MzLcTzBiWJ7o3Q2_Z... (flutter/engine#45823)
2023-09-14 [email protected] Roll Skia from 4bb29f80ed43 to 45ba26fae9cd (1 revision) (flutter/engine#45821)
2023-09-14 49699333+dependabot[bot]@users.noreply.github.com Bump html from 0.15.0 to 0.15.4 in /lib/web_ui (flutter/engine#45819)
2023-09-14 [email protected] Roll Skia from 5ff47ea11c13 to 4bb29f80ed43 (1 revision) (flutter/engine#45818)
2023-09-14 [email protected] Roll Skia from 5f18d2ead8c8 to 5ff47ea11c13 (1 revision) (flutter/engine#45815)
2023-09-14 [email protected] Roll Skia from b2a4969c7782 to 5f18d2ead8c8 (2 revisions) (flutter/engine#45814)
2023-09-14 [email protected] Roll Fuchsia Mac SDK from gHhOd3d6V3Zv6CzK2... to f4jtyOMeNSKGqqI4y... (flutter/engine#45813)
2023-09-14 [email protected] Roll Skia from ad51509c8e3f to b2a4969c7782 (3 revisions) (flutter/engine#45812)
2023-09-14 [email protected] Roll Fuchsia Linux SDK from ftcEc93bjtc0q2a6s... to 5aKvHj_QcSHJkbWjr... (flutter/engine#45808)
2023-09-14 49699333+dependabot[bot]@users.noreply.github.com Bump uuid from 3.0.6 to 4.0.0 in /lib/web_ui (flutter/engine#45794)
2023-09-13 [email protected] Roll Skia from 5c7d604c81b0 to ad51509c8e3f (1 revision) (flutter/engine#45802)
2023-09-13 [email protected] Compile a platform dill for dart2wasm (flutter/engine#45797)
2023-09-13 [email protected] Roll Skia from a30fbf83f2e9 to 5c7d604c81b0 (2 revisions) (flutter/engine#45800)

Also rolling transitive DEPS:
  fuchsia/sdk/core/linux-amd64 from ftcEc93bjtc0 to MzLcTzBiWJ7o
  fuchsia/sdk/core/mac-amd64 from gHhOd3d6V3Zv to FF4r9-tqhioB

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
harryterkelsen pushed a commit that referenced this pull request Oct 23, 2023
@godofredoc @harryterkelsen
Fix script (#45598)
3d690e6 
Makes mac framework readable and executable by all.

Bug: flutter/flutter#132725

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gspencergoog gspencergoog gspencergoog approved these changes

@christopherfujino christopherfujino Awaiting requested review from christopherfujino

Assignees
No one assigned
Labels
autosubmit Merge PR when tree becomes green via auto submit App
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@godofredoc @gspencergoog