Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

first iOS implementation #18

Merged
merged 4 commits into from
Feb 23, 2019
Merged

first iOS implementation #18

merged 4 commits into from
Feb 23, 2019

Conversation

andrea689
Copy link
Collaborator

@andrea689 andrea689 commented Feb 3, 2019

Changed iOS project to Swift and added only a MapView.
Added interpretation of MapboxMapOptions and initial map configuration.
Handled map#waitForMap and map#update methods.

@tobrun
Copy link
Collaborator

tobrun commented Feb 5, 2019

This is great @andrea689! thank you for this amazing work. I'm a bit delayed in reviewing this as I don't own a hardware iOS device so I will need to revive my old macbook to run the simulator.
@yoavrofe do you have an iOS device + build environment setup?

@tobrun tobrun added the ios label Feb 5, 2019
@tobrun tobrun added this to the 0.0.2 milestone Feb 5, 2019
@yoavrofe
Copy link
Collaborator

yoavrofe commented Feb 6, 2019

Tried to run it, got:

Xcode's output:
↳
    === BUILD TARGET mapbox_gl OF PROJECT Pods WITH CONFIGURATION Debug ===
    The “Swift Language Version” (SWIFT_VERSION) build setting must be set to a supported value for targets which use Swift. Supported values are: 3.0, 4.0, 4.2. This setting can be set in the build settings editor.

@andrea689
Copy link
Collaborator Author

Check that "Swift Language Version" is set to swift 4.2 as in the attached image:
image

@yoavrofe
Copy link
Collaborator

yoavrofe commented Feb 8, 2019

Thanks, @andrea689 . I still get the following error:

screen shot 2019-02-08 at 13 25 36

@andrea689
Copy link
Collaborator Author

@yoavrofe what is the error message?

@yoavrofe
Copy link
Collaborator

yoavrofe commented Feb 9, 2019

Use of unresolved identifier 'FlutterMapboxGL'

@tobrun
Copy link
Collaborator

tobrun commented Feb 10, 2019

Hi @andrea689, have macbook updated and running. I tried taking the command line approach:

Output flutter run:

-> Installing mapbox_gl (0.0.1)
- Running pre install hooks
[!] Unable to determine Swift version for the following pods:
- mapbox_gl does not specify a Swift version and none of the targets (Runner) integrating it have the SWIFT_VERSION attribute set. Please contact the author or set the SWIFT_VERSION attribute in at least one of the targets that integrate this pod.

Would you be able to patch that up?

Full output of the command here, and flutter doctor.

deleted MapboxGLFactory.swift
@andrea689
Copy link
Collaborator Author

andrea689 commented Feb 10, 2019

@yoavrofe I had deleted MapboxGLFactory from Xcode project but not from filesystem, now I deleted it!

@tobrun I added SWIFT_VERSION attribute!

@tobrun
Copy link
Collaborator

tobrun commented Feb 11, 2019

@andrea689 awesome I don't have access to my macbook until upcoming weekend. Will try it out and report back. Thanks again for contributing!

@yoavrofe
Copy link
Collaborator

Great work, @andrea689 !

Works on the simulator and on my device (even an old one - iphone 5S). It does not auto-start on the simulator due to this problem.

It displays maps and updates the camera poiotion information on flutter. Camera position updates, etc. are not implemented yet of course, but the disable/enable compass button works (please not it should be reversed).

@yoavrofe
Copy link
Collaborator

@tobrun , I'll be glad if you could review the code and merge it.

- Add your access token to `$project_dir/example/android/app/src/values/developer-config.xml`

#### iOS
Add this lines to your Info.plist
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

these instead of this

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We will be rewriting the readme with release v0.2.0. Let's just merge and revisit later.

@tobrun
Copy link
Collaborator

tobrun commented Feb 23, 2019

@andrea689 sorry for the delay on this! code looks great. I still had some issues running but that probably is my inability of running an iOS application on the simulator 😅 For reference, uploaded the output of flutter run here.

@yoavrofe feel free to review and merge yourself. You are one of the project maintainers 😉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants