-
Notifications
You must be signed in to change notification settings - Fork 504
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
first iOS implementation #18
Conversation
This is great @andrea689! thank you for this amazing work. I'm a bit delayed in reviewing this as I don't own a hardware iOS device so I will need to revive my old macbook to run the simulator. |
Tried to run it, got:
|
Thanks, @andrea689 . I still get the following error: |
@yoavrofe what is the error message? |
Use of unresolved identifier 'FlutterMapboxGL' |
Hi @andrea689, have macbook updated and running. I tried taking the command line approach: Output
Would you be able to patch that up? Full output of the command here, and flutter doctor. |
deleted MapboxGLFactory.swift
@andrea689 awesome I don't have access to my macbook until upcoming weekend. Will try it out and report back. Thanks again for contributing! |
Great work, @andrea689 ! Works on the simulator and on my device (even an old one - iphone 5S). It does not auto-start on the simulator due to this problem. It displays maps and updates the camera poiotion information on flutter. Camera position updates, etc. are not implemented yet of course, but the disable/enable compass button works (please not it should be reversed). |
@tobrun , I'll be glad if you could review the code and merge it. |
- Add your access token to `$project_dir/example/android/app/src/values/developer-config.xml` | ||
|
||
#### iOS | ||
Add this lines to your Info.plist |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
these
instead of this
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We will be rewriting the readme with release v0.2.0. Let's just merge and revisit later.
@andrea689 sorry for the delay on this! code looks great. I still had some issues running but that probably is my inability of running an iOS application on the simulator 😅 For reference, uploaded the output of @yoavrofe feel free to review and merge yourself. You are one of the project maintainers 😉 |
Changed iOS project to Swift and added only a MapView.
Added interpretation of
MapboxMapOptions
and initial map configuration.Handled
map#waitForMap
andmap#update
methods.