Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add iOS integration #3

Closed
tobrun opened this issue Feb 2, 2019 · 6 comments
Closed

Add iOS integration #3

tobrun opened this issue Feb 2, 2019 · 6 comments
Labels
enhancement New feature or request help wanted Extra attention is needed ios
Milestone

Comments

@tobrun
Copy link
Collaborator

tobrun commented Feb 2, 2019

Original issue mapbox/flutter-mapbox-gl#61.


Current repository state only supports building a flutter plugin to be run on Android. We need to integrate repo link on the iOS side, a WIP implementation lives in https://github.com/Fontinalis/flunama.

cc @Fontinalis @yoavrofe

@tobrun tobrun added enhancement New feature or request help wanted Extra attention is needed labels Feb 2, 2019
@tobrun tobrun added this to the 0.0.2 milestone Feb 2, 2019
@andrea689
Copy link
Collaborator

If I can switch the ios part to swift, I can help you..

@tobrun
Copy link
Collaborator Author

tobrun commented Feb 2, 2019

@andrea689 go ahead, afaik no limitations on using kotlin or swift!

@andrea689
Copy link
Collaborator

andrea689 commented Feb 3, 2019

List of methods to implement

Flutter to iOS

  • map#waitForMap
  • map#update
  • camera#move
  • camera#animate
  • marker#add
  • marker#update
  • marker#remove

iOS to Flutter

  • camera#onMoveStarted
  • infoWindow#onTap
  • camera#onMove
  • camera#onIdle

@yoavrofe
Copy link
Collaborator

yoavrofe commented Feb 5, 2019

Hi Andrea!

On the Android branch we're using code ported from the Google Maps Flutter plugin. They have an iOS implementation, which I think should be quite easy to modify, even though it uses (the somewhat infamous) Objective-C.

What do you think about it?

@andrea689
Copy link
Collaborator

For me is much simplest convert Java to Swift that understand and modify Objective-C.
In this way, we also maintain a correlation between this two parts, in fact I named Swift files with the same name of Java files.

@tobrun
Copy link
Collaborator Author

tobrun commented Feb 24, 2019

An initial integration has landed in #18, thank you for picking this up @andrea689. We should start ticking out missing features for it. Closing this issue as resolved by #18

@tobrun tobrun closed this as completed Feb 24, 2019
jrolinskifdt pushed a commit to jrolinskifdt/flutter-mapbox-gl that referenced this issue Jul 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed ios
Projects
None yet
Development

No branches or pull requests

3 participants