Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix backward compatibility with Fluent::DetachProcess and Fluent::DetachMultiProcess #1522

Merged
merged 2 commits into from
Apr 12, 2017
Merged

Fix backward compatibility with Fluent::DetachProcess and Fluent::DetachMultiProcess #1522

merged 2 commits into from
Apr 12, 2017

Commits on Mar 30, 2017

  1. Add detach_process and detach_multi_process for backward compatibility 

    Because some 3rd party plugins use these methods in their code:

```ruby
class HTTPServer # w/o inheriting Fluent::Input, Fluent::Output
  include DetachMultiProcess

  def start
    detach_multi_process do
      # Do something to run HTTP server
    end
  end
end
```
    @okkez
    okkez committed Mar 30, 2017
    Configuration menu
    Copy the full SHA
    5e021a7 View commit details
    Browse the repository at this point in the history

  2. Remove redundant methods 

    Because we can assume that 3rd party plugins that use `detach_process`
or `detach_multi_process` includes `Fluent::DetachProcessMixin` or
`Fluent::DetachMultiProcessMixin`.
    @okkez
    okkez committed Mar 30, 2017
    Configuration menu
    Copy the full SHA
    f3983b3 View commit details
    Browse the repository at this point in the history