Fix backward compatibility with Fluent::DetachProcess and Fluent::DetachMultiProcess #1522
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Because some 3rd party plugins use these methods in their code:
```ruby
class HTTPServer # w/o inheriting Fluent::Input, Fluent::Output
include DetachMultiProcess
def start
detach_multi_process do
# Do something to run HTTP server
end
end
end
```
Because we can assume that 3rd party plugins that use `detach_process` or `detach_multi_process` includes `Fluent::DetachProcessMixin` or `Fluent::DetachMultiProcessMixin`.
okkez
force-pushed
the
detach-process-backward-compatibility
branch
from
a9ba4ad
to
f3983b3
Compare
|
Failed CI but the failure seems not to be related to my changes. |
|
@repeatedly Could you apply this change and release a new version? (fluent-plugin-groonga still uses 0.12 API. It will migrate to 0.14 API later. The problem will be solved at the timing.) |
|
Sorryr for the late. Merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some 3rd party plugins use these methods in their code:
See also: