Add a check that primary and secondary use custom_format or not
#1153
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| end | ||
|
|
||
| mock(d.instance.log).warn("secondary type should be same with primary one", | ||
| { :primary=>d.instance.class.to_s, :secondary=>"Fluent::Plugin::Test2Output" }) |
There was a problem hiding this comment.
Use json style hash literal instead of rocket operator.
There was a problem hiding this comment.
|
|
ganmacs
force-pushed
the
not-to-warn-about-secondary-plugin-type
branch
from
130cdb6
to
e4e2204
Compare
I don't know that 😨 |
| @@ -477,6 +488,36 @@ def waiting(seconds) | |||
|
|
|||
| i.stop; i.before_shutdown; i.shutdown; i.after_shutdown; i.close; i.terminate | |||
| end | |||
|
|
|||
| test "Warn if primary type differents from secondary type and either primary or secondary has custom_format" do | |||
There was a problem hiding this comment.
ganmacs
force-pushed
the
not-to-warn-about-secondary-plugin-type
branch
from
e4e2204
to
af8056f
Compare
| assert_not_nil o.instance_variable_get(:@secondary) | ||
| end | ||
|
|
||
| test "don't warn if primary type is same as econdary type" do |
There was a problem hiding this comment.
ganmacs
force-pushed
the
not-to-warn-about-secondary-plugin-type
branch
3 times, most recently
from
7487104
to
ec3847c
Compare
ganmacs
force-pushed
the
not-to-warn-about-secondary-plugin-type
branch
from
ec3847c
to
971eaff
Compare
|
LGTM. Thank you for contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not to warn about secondary plugin type if "standard" format is used in both of primary and secondary.
This PR closes #1150.