Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Not to warn about secondary plugin type if standard format is used in both of primary and secondary #1150

Closed
ganmacs opened this issue Aug 8, 2016 · 0 comments · Fixed by #1153
Labels
enhancement Feature request or improve operations v0.14

Comments

@ganmacs
Copy link
Member

ganmacs commented Aug 8, 2016

Now, Fluentd shows warning if secondary plugin type is different from primary plugin type. But it is nonsense in some cases in Fluentd v0.14. This propose to suppress it if both of primary and secondary use "standard" format, instead of implementing format method by themselves.

Fluentd v0.12 requires buffered output plugins to implement format method by themselves. It means that different plugin types have different formatting of buffer chunks.
Secondary plugin uses buffer chunks formatted by primary plugins. So different plugin types between primary and secondary should causes unexpected errors or failures to operate buffer chunks.

But Fluentd v0.14 has "standard" format, so different plugin types can share the way to format buffer chunks by using standard format.
There is no need to warn about type difference between primary and secondary if both these use standard format.
It can be implemented by checking plugins implement format method by themselves or not.

@ganmacs ganmacs changed the title Stop to output a warning log when a primary type and a secondary type don't override format method. Stop to output a warning log when a primary type and a secondary type don't override format method Aug 8, 2016
@tagomoris tagomoris changed the title Stop to output a warning log when a primary type and a secondary type don't override format method Not to warn about secondary plugin type if standard format is used in both of primary and secondary Aug 8, 2016
@tagomoris tagomoris added enhancement Feature request or improve operations v0.14 labels Aug 8, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Feature request or improve operations v0.14
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants