Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

packaging: update Windows build to detain fluent-bit artefacts #4695

Merged
merged 3 commits into from
Jan 27, 2022

Conversation

patrick-stephens
Copy link
Contributor

During smoke testing for #4635 I noticed that the Appveyor builds are no longer detaining any artefacts.
The reason is a change in the default name to fluent-bit for the packages unless FLB_TD=On is defined.

Signed-off-by: Patrick Stephens [email protected]


Enter [N/A] in the box, if an item is not applicable to your change.

Testing
Before we can approve your change; please submit the following in a comment:

  • Example configuration file for the change
  • Debug log output from testing the change
  • Attached Valgrind output that shows no leaks or memory corruption was found

If this is a change to packaging of containers or native binaries then please confirm it works for all targets.

Documentation

  • Documentation required for this feature

Backporting

  • Backport to latest stable release.

Fluent Bit is licensed under Apache 2.0, by submitting this pull request I understand that this code will be released under the terms of that license.

Copy link
Collaborator

@niedbalski niedbalski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@niedbalski niedbalski merged commit db14c6f into master Jan 27, 2022
@niedbalski niedbalski deleted the appveyor_fluent_bit branch January 27, 2022 12:45
@patrick-stephens patrick-stephens added this to the Fluent Bit v1.9 milestone Feb 2, 2022
patrick-stephens added a commit that referenced this pull request Feb 9, 2022
* packaging: update Windows build to detain fluent-bit artefacts

Signed-off-by: Patrick Stephens <[email protected]>

* packaging: build td-agent-bit too

Signed-off-by: Patrick Stephens <[email protected]>

* workflows: skip unit tests for this type of update

Signed-off-by: Patrick Stephens <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants