Default config file doesn't work on Windows

[walbers]

Bug Report

Describe the bug
The fluent-bit.conf file downloaded with the 64 bit zip for Windows doesn't work on Windows.

To Reproduce

• Windows allows you to create the service but the service will never get out of the STOPPED state
• Steps to reproduce the problem:

1. sc.exe create fluent-bit binPath= "C:\test\bin\fluent-bit.exe -c C:\test\conf\fluent-bit.conf"
2. sc.exe start fluent-bit
3. sc.exe query fluent-bit
4. Query output:

SERVICE_NAME: fluent-bit
        TYPE               : 10  WIN32_OWN_PROCESS
        STATE              : 1  STOPPED
        WIN32_EXIT_CODE    : 1067  (0x42b)
        SERVICE_EXIT_CODE  : 0  (0x0)
        CHECKPOINT         : 0x0
        WAIT_HINT          : 0x0

Expected behavior
For the service to be started. This was fixed after hours of debugging. I tried the config file found here and everything worked fine.

Your Environment

• Version used: Latest
• Configuration: default everything except moved to folder named test
• Operating System and version: Windows 10
• Filters and plugins: None

[agup006]

@walbers I'm changing the title to Windows, @fujimotos have you seen this before?

[fujimotos]

I'm changing the title to Windows, @fujimotos have you seen this before?

@agup006 The reason is pretty simple: the default configuration file
fluent-bit.conf is meant for Unix. It's not never intended for Windows.

For reference, I posted a minimum configuration that works on Windows
to #4647. I hope that patch helps.

[patrick-stephens]

Similar to the Linux smoke tests we need to add one for Windows as well to catch these errors in CI, I'll be doing that when we transition the Windows build over into the same pipeline. @niedbalski is there an existing issue for the Windows CI updates to link?

[patrick-stephens]

@fujimotos do you want me to merge that config over to the docs https://docs.fluentbit.io/manual/installation/windows?
That'll help prevent this issue as well.

EDIT: created a PR here: fluent/fluent-bit-docs#676

[niedbalski]

@patrick-stephens #3720 intends to address the windows builds issue. As for this specific, In my opinion a simple smoke test that uses the configuration pointed by @fujimotos can help here.

[patrick-stephens]

@patrick-stephens #3720 intends to address the windows builds issue. As for this specific, In my opinion a simple smoke test that uses the configuration pointed by @fujimotos can help here.

Yeah I'll look at that next week if I can, just add a job for smoke testing it rather than the full CI.

[patrick-stephens]

@fujimotos also did a follow up PR that makes the new config file the default which is super helpful and what I'll try to pull down for testing/verification as simplifies things: #4679

[patrick-stephens]

@patrick-stephens #3720 intends to address the windows builds issue. As for this specific, In my opinion a simple smoke test that uses the configuration pointed by @fujimotos can help here.

Yeah I'll look at that next week if I can, just add a job for smoke testing it rather than the full CI.

I've got a working POC now I'll aim to integrate into the workflows: https://github.com/patrick-stephens/fluent-bit-release-test/runs/4954750346?check_suite_focus=true

https://github.com/patrick-stephens/fluent-bit-release-test/blob/42072c455294e1d3bf4def7f9d725171e4cca38e/.github/workflows/windows-ci.yaml