Add AcceptJob #259
Merged
Add AcceptJob #259
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seitau
force-pushed
the
fix-accept
branch
8 times, most recently
from
903af53
to
08523a9
Compare
seitau
commented
Jan 27, 2022
|
@seita-uc Thank you for the PR, it looks great! Just one thing: could we avoid the usage of psql here if you tried the custom The function can be found here: datastore/gorm/transaction.go An example usage can be found here: keys/store_gorm.go#L55 It should be a drop-in replacement for the |
|
Note: we just removed the |
|
@latenssi Thank you for review! I missed the change of refactoring transactions so I'm gonna fix to follow the existing implementation. |
seitau
commented
Jan 31, 2022
latenssi
approved these changes
Feb 1, 2022
nanuuki
approved these changes
Feb 1, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #241 #94
Added
AcceptJobto job store which updates job asACCEPTEDin transaction.This feature will prevent jobs from being executed multiple times concurrently.