Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Config refactor, remove support for -envfile #258

Merged
merged 7 commits into from
Jan 31, 2022
Merged

Conversation

latenssi
Copy link
Member

@latenssi latenssi commented Jan 25, 2022

This PR will stop loading environment variables from a file. It also cleans up the environment handling during testing.

@latenssi latenssi marked this pull request as ready for review January 25, 2022 13:19
Copy link
Contributor

@nanuuki nanuuki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 👍

@latenssi latenssi changed the title Config refactor Config refactor, remove support for -envfile Jan 31, 2022
@latenssi latenssi merged commit 8f2bd46 into main Jan 31, 2022
@latenssi latenssi deleted the config-refactor branch January 31, 2022 08:01
@latenssi latenssi mentioned this pull request Jan 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants