Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Packaged versions don't support trailscraper guess #110

Closed
flosell opened this issue Jun 3, 2020 · 2 comments
Closed

Packaged versions don't support trailscraper guess #110

flosell opened this issue Jun 3, 2020 · 2 comments
Labels

Comments

@flosell
Copy link
Owner

flosell commented Jun 3, 2020

Looks like known-iam-actions.txt is not distributed in homebrew (introduced in #105) and pip:

$ echo '{
   "Version":"2012-10-17",
   "Statement":[
      {
         "Effect":"Allow",
         "Action":[
            "s3:GetObject"
         ],
         "Resource":"arn:aws:s3:::my_corporate_bucket/home/${aws:userid}/*"
      }
   ]
}' | trailscraper guess
[...]
  File "/usr/local/Cellar/trailscraper/0.5.1/libexec/lib/python3.8/site-packages/trailscraper/iam.py", line 176, in all_known_iam_permissions
    with open(os.path.join(os.path.dirname(__file__), 'known-iam-actions.txt')) as iam_file:
FileNotFoundError: [Errno 2] No such file or directory: '/usr/local/Cellar/trailscraper/0.5.1/libexec/lib/python3.8/site-packages/trailscraper/known-iam-actions.txt'
@flosell flosell added the bug label Jun 3, 2020
@flosell flosell changed the title Homebrew-installed versions don't support trailscraper guess Packaged versions don't support trailscraper guess Jun 3, 2020
flosell added a commit that referenced this issue Jun 3, 2020
@flosell
Copy link
Owner Author

flosell commented Jun 3, 2020

Fixed in latest release 0.6.1 in pip.
Homebrew not released yet.

@flosell
Copy link
Owner Author

flosell commented Jun 5, 2020

Homebrew released as well, fixed.

@flosell flosell closed this as completed Jun 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant