Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Homebrew support #105

Closed
nitrocode opened this issue Apr 30, 2020 · 5 comments
Closed

Homebrew support #105

nitrocode opened this issue Apr 30, 2020 · 5 comments

Comments

@nitrocode
Copy link
Contributor

Would be nice to install using

brew install trailscraper
@kmcquade
Copy link

For anyone who wants this, feel free to use this PR I made to parliament as a reference. duo-labs/parliament#111

@flosell
Copy link
Owner

flosell commented May 6, 2020

Hi @nitrocode, similar to our conversation on my other project, agreed, this would be very helpful and I'm happy to support this however I can.
However, I'd appreciate some help with the initial submission due to homebrews policy against self-submitting.

@kmcquade
Copy link

kmcquade commented May 7, 2020

@flosell We can take a different approach instead of submitting it to homebrew proper. You can add a folder in the root of the repository titled HomebrewFormula or Formula with the trailscraper.rb in it, generated by homebrew-pypi-poet. Then users can run:

brew tap flosell/trailscraper https://github.com/flosell/trailscraper
brew install trailscraper

... and it will upgrade for them.

I also did this here: https://github.com/salesforce/cloudsplaining/blob/master/.github/workflows/publish.yml#L60

@nitrocode
Copy link
Contributor Author

Homebrew/homebrew-core#54818

nitrocode added a commit to nitrocode/trailscraper that referenced this issue May 18, 2020
flosell pushed a commit that referenced this issue May 20, 2020
@flosell
Copy link
Owner

flosell commented May 20, 2020

Homebrew PR is merged, brew install trailscraper works now! Thank you @nitrocode for contributing this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants