Remove code that updates the PK #251
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
And note the internal inconsistency.
|
I also added an explicit test to verify the hashing algorithm upgrade. Not changing the PK makes that much easier than it was previously. |
Codecov Report
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. @@ Coverage Diff @@
## master #251 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 24 24
Lines 622 635 +13
=========================================
+ Hits 622 635 +13
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Closed
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
And note the internal inconsistency.
Removes the PK update added in #244 and keeps the PK as-is despite it no longer reflecting the hashed key. The comments about the inconsistency can be removed once #128 is fixed.