Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Version 2.4.0 #248

Closed
wants to merge 2 commits into from
Closed

Version 2.4.0 #248

wants to merge 2 commits into from

Conversation

florimondmanca
Copy link
Owner

@florimondmanca florimondmanca commented Sep 12, 2023

2.4.0 - 2023-09-18

Removed

Added

Fixed

@codecov-commenter
Copy link

codecov-commenter commented Sep 12, 2023

Codecov Report

Merging #248 (f5f7c99) into master (f93a1c4) will not change coverage.
The diff coverage is 100.00%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

@@            Coverage Diff            @@
##            master      #248   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           24        24           
  Lines          635       635           
=========================================
  Hits           635       635           
Files Changed Coverage Δ
src/rest_framework_api_key/__init__.py 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@beda42
Copy link

beda42 commented Sep 13, 2023

👍

@florimondmanca
Copy link
Owner Author

Let's see if we might need an upgrade guide for 2.4 after all, considering #128 (comment)

CHANGELOG.md Outdated Show resolved Hide resolved
@florimondmanca
Copy link
Owner Author

florimondmanca commented Sep 17, 2023

I'm tempted to make this a 3.0 release in line with what happened for 2.0 when Python and Django / DRF version support changed.

The SHA512 hasher and .has_object_permission() changes, although not-breaking, are also fairly significant, so it might be worth rolling a new major so that at least people with pinned dependencies can upgrade more consciously.

@davidfischer @beda42 Thoughts?

@florimondmanca florimondmanca changed the title Version 2.4.0 Version 3.0.0 Sep 17, 2023
@beda42
Copy link

beda42 commented Sep 18, 2023

I think that it would make a lot of sense calling this 3.0.0. But in that case, maybe it would also make sense to change how the PK is created (that is for new objects only). Would using just the prefix be a problem? It seems like it has the role of a PK anyway...

It could have the same type and because it would only be used for new objects (old ones will keep current PK), no migration will be necessary.

@florimondmanca
Copy link
Owner Author

florimondmanca commented Sep 18, 2023

I think that it would make a lot of sense calling this 3.0.0. But in that case, maybe it would also make sense to change how the PK is created (that is for new objects only). Would using just the prefix be a problem? It seems like it has the role of a PK anyway...

Changing the PK only for new objects is a pretty interesting idea.

But I don’t think we need to block the release of the performance fix on also implementing the PK change.

I’d be okay if we release that later on, eg as a 4.0.

#252 suggests that releasing the perf improvement would relieve a lot of folks in the community.

I’ll make the changes to the docs to hint at using 3.*, then I think we can issue the release.

@florimondmanca florimondmanca changed the title Version 3.0.0 Version 2.4.0 Sep 30, 2023
@florimondmanca
Copy link
Owner Author

Okay, closing to open a 3.0 release PR.

@florimondmanca florimondmanca deleted the release/2.4.0 branch September 30, 2023 13:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants