-
Notifications
You must be signed in to change notification settings - Fork 103
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Version 2.4.0 #248
Version 2.4.0 #248
Conversation
Codecov Report
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. @@ Coverage Diff @@
## master #248 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 24 24
Lines 635 635
=========================================
Hits 635 635
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
👍 |
Let's see if we might need an upgrade guide for 2.4 after all, considering #128 (comment) |
3db85fe
to
a4bac81
Compare
I'm tempted to make this a 3.0 release in line with what happened for 2.0 when Python and Django / DRF version support changed. The SHA512 hasher and @davidfischer @beda42 Thoughts? |
I think that it would make a lot of sense calling this 3.0.0. But in that case, maybe it would also make sense to change how the PK is created (that is for new objects only). Would using just the prefix be a problem? It seems like it has the role of a PK anyway... It could have the same type and because it would only be used for new objects (old ones will keep current PK), no migration will be necessary. |
Changing the PK only for new objects is a pretty interesting idea. But I don’t think we need to block the release of the performance fix on also implementing the PK change. I’d be okay if we release that later on, eg as a 4.0. #252 suggests that releasing the perf improvement would relieve a lot of folks in the community. I’ll make the changes to the docs to hint at using 3.*, then I think we can issue the release. |
Okay, closing to open a 3.0 release PR. |
2.4.0 - 2023-09-18
Removed
Added
Fixed
.is_valid()
is called. (Pull Use a fast key hasher instead of password hashers #244, Pull Remove code that updates the PK #251).has_object_permission()
implementation onBaseHasAPIKey
when using DRF 3.14.0 or above. (Pull Drop redundant .has_object_permission impl on DRF 3.14.0 or above #240)