feat: Added max_expected_flow_w configuration #34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…more intuitively.
shadow7412
changed the title
Closed
|
Thank you for your pull request. |
|
I have reviewed and tested your PR and I overall I'm pretty happy with the new formula. 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The idea here is that that max_expected_flow_w config will set a hard minimum for the total value when calculating animations.
This should result in linearly slower animations under that value (but the current scaling when over).
Note that I wasn't entirely sure how to quickly test my changes, so they are just eyeballed for now. I figured it'd be worth raising the PR anyway, in case you wouldn't mind testing it. Otherwise it can stay stagnant until I confirm it actually works as expected.
The biggest assumption I've made is that
circleRate'stotalis in watts.Also my IDE apparently cleaned up some trailing whitespace. I can revert this if you feel strongly about it.