Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flow Formula suggestion #25

Closed
shadow7412 opened this issue Mar 27, 2023 · 7 comments
Closed

Flow Formula suggestion #25

shadow7412 opened this issue Mar 27, 2023 · 7 comments
Labels
enhancement New feature or request

Comments

@shadow7412
Copy link
Contributor

At the moment it takes the current maximum and minimum currents. I think if we had the ability to set our own max and minimum values (either instead of or in addition to the real ones) we'd get a more realistic animation.

Eg, If I set my maximum to 5kw, then even if the total system is only seeing 300W the animation would be slow, because we have the hardcoded maximum. Also, hardcoding 0W to minimum would mean that everything should animate consistently relative to that range.

If that was acceptable behaviour, I could see the value of 0 being used instead of the calculated minimum and a config-driven value for maximum working quite well.

@flixlix
Copy link
Owner

flixlix commented Mar 27, 2023

I like this suggestion, but I am currently focusing on other additional features, so it will take some time.
@shadow7412 would you be willing / capable to submit a PR for this feature?

@flixlix flixlix added the enhancement New feature or request label Mar 27, 2023
@shadow7412
Copy link
Contributor Author

I'm unfamiliar with the HACS layout, but I'll give it a whirl time permitting.

@shadow7412
Copy link
Contributor Author

See #34

@flixlix
Copy link
Owner

flixlix commented Mar 31, 2023

merged #34
Thank you for your support!

@flixlix flixlix closed this as completed Mar 31, 2023
@shadow7412
Copy link
Contributor Author

I think we might need more work on this... the difference between 25W and 1kW seems indistinguishable...

@flixlix
Copy link
Owner

flixlix commented Mar 31, 2023

Yes I noticed this right after merging. I didn't have this issue while testing, because I set max_expected_flow_w to 10, so then it makes no difference... I'm currently working on other features though, so I don't have much time for this

@flixlix flixlix reopened this Mar 31, 2023
@flixlix
Copy link
Owner

flixlix commented Apr 11, 2023

I'm currently working on another flow rate formula, I'll see when I can finish it. For now I'll close this issue. Thank you anyways for your PR 👍

@flixlix flixlix closed this as not planned Won't fix, can't repro, duplicate, stale Apr 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants