-
-
Notifications
You must be signed in to change notification settings - Fork 75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Flow Formula suggestion #25
Comments
I like this suggestion, but I am currently focusing on other additional features, so it will take some time. |
I'm unfamiliar with the HACS layout, but I'll give it a whirl time permitting. |
See #34 |
merged #34 |
I think we might need more work on this... the difference between 25W and 1kW seems indistinguishable... |
Yes I noticed this right after merging. I didn't have this issue while testing, because I set |
I'm currently working on another flow rate formula, I'll see when I can finish it. For now I'll close this issue. Thank you anyways for your PR 👍 |
At the moment it takes the current maximum and minimum currents. I think if we had the ability to set our own max and minimum values (either instead of or in addition to the real ones) we'd get a more realistic animation.
Eg, If I set my maximum to 5kw, then even if the total system is only seeing 300W the animation would be slow, because we have the hardcoded maximum. Also, hardcoding 0W to minimum would mean that everything should animate consistently relative to that range.
If that was acceptable behaviour, I could see the value of 0 being used instead of the calculated minimum and a config-driven value for maximum working quite well.
The text was updated successfully, but these errors were encountered: