Provide catkin package.xml per ROS REP 136

[c-andy-martin]

This provides the least intrusive, but most automated and correct
method for releasing non-catkin packages through the ROS
infrastructure.

These changes allow me to use catkin tools to build fcl, and to
have other catkin packages depend on fcl directly.

---

This change is 

[jslee02]

I'm not currently maintaining FCL actively. I guess @sherm1 or @SeanCurtis-TRI would be more make sense to be the maintainer.

[c-andy-martin]

OK, I changed it to both of them.

[sherm1]

We are creating an [email protected] address so that various people in TRI's geometry group can serve as maintainers. Can you list the maintainer as
<maintainer email="[email protected]">TRI Geometry Team</maintainer>
?

[jmirabel]

Note that the way this is setup, the version number must
be maintained in two places. I'm not sure how to resolve that.

A few lines in CMake are sufficient to parse package.xml and extract the version:

FILE(READ package.xml PACKAGE_XML)
STRING(REGEX MATCH "<version>[0-9]+\\.[0-9]+\\.[0-9]+</version>" DIRTY_VERSION_STRING ${PACKAGE_XML})

STRING(REGEX REPLACE "^<version>([0-9]+)\\.[0-9]+\\.[0-9]+</version>" "\\1" major_vers "${DIRTY_VERSION_STRING}")
STRING(REGEX REPLACE "^<version>[0-9]+\\.([0-9])+\\.[0-9]+</version>" "\\1" minor_vers "${DIRTY_VERSION_STRING}")
STRING(REGEX REPLACE "^<version>[0-9]+\\.[0-9]+\\.([0-9]+)</version>" "\\1" patch_vers "${DIRTY_VERSION_STRING}")

Note if CMake >= 3.9, you can catch groups in regular expression using CMAKE_MATCH_<n>

[c-andy-martin]

We are creating an [email protected] address so that various people in TRI's geometry group can serve as maintainers. Can you list the maintainer as
<maintainer email="[email protected]">TRI Geometry Team</maintainer>
?

Done

[c-andy-martin]

Note that the way this is setup, the version number must
be maintained in two places. I'm not sure how to resolve that.

A few lines in CMake are sufficient to parse package.xml and extract the version:

FILE(READ package.xml PACKAGE_XML)
STRING(REGEX MATCH "<version>[0-9]+\\.[0-9]+\\.[0-9]+</version>" DIRTY_VERSION_STRING ${PACKAGE_XML})

STRING(REGEX REPLACE "^<version>([0-9]+)\\.[0-9]+\\.[0-9]+</version>" "\\1" major_vers "${DIRTY_VERSION_STRING}")
STRING(REGEX REPLACE "^<version>[0-9]+\\.([0-9])+\\.[0-9]+</version>" "\\1" minor_vers "${DIRTY_VERSION_STRING}")
STRING(REGEX REPLACE "^<version>[0-9]+\\.[0-9]+\\.([0-9]+)</version>" "\\1" patch_vers "${DIRTY_VERSION_STRING}")

Note if CMake >= 3.9, you can catch groups in regular expression using CMAKE_MATCH_<n>

Excellent! Done.

[c-andy-martin]

I have addressed the issues I think. Thanks to TRI for supporting FCL!

[sherm1]

Thanks, Andy. This looks good to me but I don't know much about this build system. Can we get a quick review by a more-knowledgeable person? @j-rivero @scpeters, or @jamiesnape maybe?

Reviewed 1 of 2 files at r1, 2 of 2 files at r2.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @SeanCurtis-TRI and @sherm1)

[jamiesnape]

Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @c-andy-martin, @SeanCurtis-TRI, and @sherm1)

---

CMakeModules/FCLVersion.cmake, line 2 at r2 (raw file):

# set the version in a way CMake can use
FILE(READ package.xml PACKAGE_XML)

Use lowercase for FILE and STRING.

[c-andy-martin]

Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @c-andy-martin, @SeanCurtis-TRI, and @sherm1)

CMakeModules/FCLVersion.cmake, line 2 at r2 (raw file):

# set the version in a way CMake can use
FILE(READ package.xml PACKAGE_XML)

Use lowercase for FILE and STRING.

Done

[c-andy-martin]

Reviewable status: 2 of 3 files reviewed, 2 unresolved discussions (waiting on @jamiesnape, @SeanCurtis-TRI, and @sherm1)

---

CMakeModules/FCLVersion.cmake, line 2 at r2 (raw file):

Previously, jamiesnape (Jamie Snape) wrote…

Use lowercase for FILE and STRING.

Done.

[jamiesnape]

The one thing I don't like about this is that when we switch to CMake 3 it is nice to be able to use the VERSION argument to project(). I guess we can live without that, though.

Reviewable status: 2 of 3 files reviewed, 2 unresolved discussions (waiting on @c-andy-martin, @SeanCurtis-TRI, and @sherm1)

---

CMakeLists.txt, line 291 at r3 (raw file):

# Install catkin package.xml
install(FILES package.xml DESTINATION ${CMAKE_INSTALL_DATAROOTDIR}/fcl)

"${CMAKE_INSTALL_DATAROOTDIR}/${PROJECT_NAME}"

[c-andy-martin]

---

CMakeLists.txt, line 291 at r3 (raw file):

Previously, jamiesnape (Jamie Snape) wrote…

"${CMAKE_INSTALL_DATAROOTDIR}/${PROJECT_NAME}"

Done.

[jamiesnape]

Reviewed 1 of 2 files at r2, 1 of 1 files at r3, 1 of 1 files at r4.
Dismissed @jslee02 from a discussion.
Reviewable status: complete! all files reviewed, all discussions resolved