2D simulation boundary warning #693
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
momchil-flex
force-pushed
the
pre/1.9.0
branch
from
ea505b8
to
e06f679
Compare
momchil-flex
force-pushed
the
shash/warn_2d_sim
branch
from
388be19
to
ef884fb
Compare
|
Looks good - could you just rebase and add a line to the changelog about this? You need to rebase to get the changelog template sections. |
momchil-flex
approved these changes
Feb 21, 2023
- update changelog
shashwat-sh
force-pushed
the
shash/warn_2d_sim
branch
from
ef884fb
to
905cbd1
Compare
Done |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Warn if a 2D simulation uses an absorbing boundary in the zero dimension. Eventually we may want to automatically switch to a periodic boundary.
Not urgent; we can merge this later on after discussing further.