Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2D Simulation plots lack PML #823

Closed
tylerflex opened this issue Apr 4, 2023 · 4 comments
Closed

2D Simulation plots lack PML #823

tylerflex opened this issue Apr 4, 2023 · 4 comments
Assignees
Labels
Bug something isnt working

Comments

@tylerflex
Copy link
Collaborator

Encountered an issue where the sim.plot() was missing PMLs for a 2D simulation. Inspecting the Simulation._make_pml_boxes(), it seems the boxes have size 0 in the normal direction, so they probably are just not being found. We can put a condition to expand the PML boxes to infinity if any of the Simulation.size is 0 along that dimension perhaps.

@tylerflex tylerflex added the Bug something isnt working label Apr 4, 2023
@tylerflex tylerflex changed the title sometimes the Simulation plot doesn't have PML for 2D 2D Simulation plots lack PML Apr 4, 2023
@tylerflex tylerflex self-assigned this Apr 6, 2023
@momchil-flex
Copy link
Collaborator

Sorry, I'm confused, you mean PML along the dimension where the size is 0? That's not a good setup, in fact I think we even warn about it?

@momchil-flex
Copy link
Collaborator

#693

@tylerflex
Copy link
Collaborator Author

No, take a look at the PR: #830

It just adds some thickness to the pml boxes for plotting only along the dimensions where sim.size == 0.

@momchil-flex
Copy link
Collaborator

Oh ok.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug something isnt working
Projects
None yet
Development

No branches or pull requests

2 participants