-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: GDS export wrappers in JaxSimulation
(#1334)
#1660
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just took a quick look, could we also add
- the other gds conversion methods (I think there's also
to_gds_file()
, might be one or two more but that's the main one people will use I think). - Just copy over the docstring from the original methods so people can see the parameters (I realize this is kind of ugly but it's what we have until we can better refactor things).
- Add a line in the changelog under "added" in "unreleased"
Thanks!
Hey @tylerflex, |
Ah, but |
oh I see. hm, maybe we dont need the specific gdstk and gdspy ones but if you're already working on them, it wouldn't hurt. Good to know that the to_gds_file will work automatically, I guess just mention all of them that will work from JaxSimulation now in the changelog and should be good. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, thanks @yaugenst-flex , just a couple minor comments and also please squash the commits to 1 (or 2 maybe with one of them to fix the gds{py, tk} methods) if possible). Thanks!
b74c29c
to
b7be34e
Compare
Done! |
1dd79d4
to
05edaaf
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! thanks @yaugenst-flex . I will merge once the tests pass!
Fixes #1334 by overriding
to_gds()
inJaxSimulation
to callself.to_simulation()
first. Addresses bothto_gds()
andto_gds_file()
this way.