Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor updates to adjoint notebook removing to_simulation() calls where possible #107

Merged
merged 1 commit into from
May 3, 2024

Conversation

yaugenst-flex
Copy link
Contributor

Updates a few notebooks to remove JaxSimulation.to_simulation() calls where safe to do so, particularly before to_gds() calls as this is fixed as of flexcompute/tidy3d#1660.
The changes are very conservative, I did not remove to_simulation() calls if the resulting simulation object is being reused for other things, such as running a simulation.

Copy link
Collaborator

@tylerflex tylerflex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks for taking care of this! (there might be a few other instances, eg in the mode converter but it's ok, we can just clean them up when we notice them)

@tylerflex tylerflex merged commit e6f5a19 into pre/2.7 May 3, 2024
@yaugenst-flex yaugenst-flex deleted the yaugenst-flex/to_gds_update branch May 3, 2024 12:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants