Skip progress report when Content-Length is unavailable #86
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for fixing it! |
|
Anything holding this back? Would be nice to get this out in a release, it would fix installation of the |
|
Sorry, nothing is holding this back except my inability to find time to work on OSS this month. Will get a release out this weekend. |
steventux
pushed a commit
to alphagov/govuk-content-schemas
that referenced
this pull request
Oct 11, 2018
Miniportile is used to retrieve jsonnet from github. The progress reporter in miniportile can't handle a nil content-length response which github sends with content- encoding: Chunked. There's a fix flavorjones/mini_portile#86 which needs merging into the gem at which point we can remove this env var.
|
@flavorjones Any chance you'll get to look at this again soon? |
|
Hey all -- apologies for the slow response. I've merged this! Will cut a release shortly. |
|
mini_portile2 v2.4.0 has been shipped. Thanks again! |
kevindew
added a commit
to alphagov/govuk-content-schemas
that referenced
this pull request
Dec 6, 2018
This updates our gems most noticably mini_portile2 which has had an issue making it difficult to install jsonnet. See flavorjones/mini_portile#86 for more details.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should fix #85