New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unable to download files when Content-Encoding is chunked #85

Closed

eagletmt opened this issue Sep 3, 2018 · 1 comment · Fixed by #86

Contributor

eagletmt commented Sep 3, 2018

MiniPortile#download_file_http relies on the Content-Length header, but it isn't sent when Content-Encoding is chunked. In this case, content_length_proc is called with nil.
https://github.com/flavorjones/mini_portile/blob/v2.3.0/lib/mini_portile2/mini_portile.rb#L454-L460
Although mini_portile requests with Accept-Encoding: identity, some servers (e.g., GitHub) respond with Content-Encoding: chunked

The text was updated successfully, but these errors were encountered:

eagletmt mentioned this issue

Skip progress report when Content-Length is unavailable #86

Merged

koenrh mentioned this issue

Update remote location of 'librdkafka' tarball to avoid GitHub rate limits karafka/rdkafka-ruby#43

Merged

flavorjones closed this as completed in #86

Owner

flavorjones commented Dec 12, 2018

Closing the loop: this was addressed via #86 in v2.4.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment