Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

backend: Autogenerate default oidc-valid-redirect-urls #541

Merged
merged 2 commits into from
Jan 11, 2022
Merged

backend: Autogenerate default oidc-valid-redirect-urls #541

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1a03dcb
backend: Update oidc-valid-redirect-urls help string
yolossn Dec 20, 2021
b2d08f5
backend: Autogenerate default OIDC valid redirect URLs
yolossn Dec 24, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 13 additions & 3 deletions backend/cmd/nebraska/nebraska.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,15 +62,15 @@ var (
oidcClientID = flag.String("oidc-client-id", "", "OIDC client ID used for authentication")
oidcClientSecret = flag.String("oidc-client-secret", "", fmt.Sprintf("OIDC client Secret used for authentication; can be taken from %s env var too", oidcClientIDEnvName))
oidcIssuerURL = flag.String("oidc-issuer-url", "", fmt.Sprintf("OIDC issuer URL used for authentication;can be taken from %s env var too", oidcClientSecretEnvName))
oidcValidRedirectURLs = flag.String("oidc-valid-redirect-urls", "http://localhost:8000/*", "OIDC valid Redirect URLs")
oidcValidRedirectURLs = flag.String("oidc-valid-redirect-urls", "", "OIDC valid Redirect URLs; accepts comma separated values and supports wildcards (*), for example http://nebraska.example.io/*. If not set defaults to <nebraska-url>/*")
oidcAdminRoles = flag.String("oidc-admin-roles", "", "comma-separated list of accepted roles with admin access")
oidcViewerRoles = flag.String("oidc-viewer-roles", "", "comma-separated list of accepted roles with viewer access")
oidcRolesPath = flag.String("oidc-roles-path", "roles", "json path in which the roles array is present in the id token")
oidcScopes = flag.String("oidc-scopes", "openid", "comma-separated list of scopes to be used in OIDC")
oidcSessionAuthKey = flag.String("oidc-session-secret", "", fmt.Sprintf("Session secret used for authenticating sessions in cookies used for storing OIDC info , will be generated if none is passed; can be taken from %s env var too", oidcSessionAuthKeyEnvName))
oidcSessionCryptKey = flag.String("oidc-session-crypt-key", "", fmt.Sprintf("Session key used for encrypting sessions in cookies used for storing OIDC info, will be generated if none is passed; can be taken from %s env var too", oidcSessionCryptKeyEnvName))
oidcManagementURL = flag.String("oidc-management-url", "", "OIDC management url for managing the account")
oidcLogutURL = flag.String("oidc-logout-url", "", "URL to logout the user from current session")
oidcLogoutURL = flag.String("oidc-logout-url", "", "URL to logout the user from current session")
flatcarUpdatesURL = flag.String("sync-update-url", "https://public.update.flatcar-linux.net/v1/update/", "Flatcar update URL to sync from")
checkFrequencyVal = flag.String("sync-interval", "1h", "Sync check interval (the minimum depends on the number of channels to sync, e.g., 8m for 8 channels incl. different architectures)")
appLogoPath = flag.String("client-logo", "", "Client app logo, should be a path to svg file")
Expand Down Expand Up @@ -165,6 +165,16 @@ func mainWithError() error {

url.Path = "/login/cb"

if *oidcValidRedirectURLs == "" {
url, err := url.Parse(*nebraskaURL)
if err != nil {
return fmt.Errorf("nebraska-url is invalid, can't generate valid redirect URL, Err: %w", err)
}
url.Path = strings.TrimSuffix(url.Path, "/")
generatedValidRedirectURLs := fmt.Sprintf("%s/*", url.String())
oidcValidRedirectURLs = &generatedValidRedirectURLs
}

clientID, err := obtainOIDCClientID(*oidcClientID)
if err != nil {
return err
Expand All @@ -182,7 +192,7 @@ func mainWithError() error {
CallbackURL: url.String(),
ValidRedirectURLs: strings.Split(*oidcValidRedirectURLs, ","),
ManagementURL: *oidcManagementURL,
LogoutURL: *oidcLogutURL,
LogoutURL: *oidcLogoutURL,
AdminRoles: strings.Split(*oidcAdminRoles, ","),
ViewerRoles: strings.Split(*oidcViewerRoles, ","),
Scopes: strings.Split(*oidcScopes, ","),
Expand Down