backend: Autogenerate default oidc-valid-redirect-urls #541
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joaquimrocha
requested changes
Dec 22, 2021
This patch improves the help string of oidc-valid-redirect-urls by adding explanation for wildcard support. Signed-off-by: Santhosh Nagaraj S <[email protected]>
yolossn
force-pushed
the
fix-oidc-valid-urls
branch
from
64a9c73 to
38e6249
Compare
yolossn
changed the title
joaquimrocha
requested changes
Jan 5, 2022
backend/cmd/nebraska/nebraska.go
Outdated
| @@ -62,15 +62,15 @@ var ( | |||
| oidcClientID = flag.String("oidc-client-id", "", "OIDC client ID used for authentication") | |||
| oidcClientSecret = flag.String("oidc-client-secret", "", fmt.Sprintf("OIDC client Secret used for authentication; can be taken from %s env var too", oidcClientIDEnvName)) | |||
| oidcIssuerURL = flag.String("oidc-issuer-url", "", fmt.Sprintf("OIDC issuer URL used for authentication;can be taken from %s env var too", oidcClientSecretEnvName)) | |||
| oidcValidRedirectURLs = flag.String("oidc-valid-redirect-urls", "http://localhost:8000/*", "OIDC valid Redirect URLs accepts comma separated values with wildcard *, for example if nebraska is hosted at http://nebraska.kinvolk.io the value should be http://nebraska.kinvolk.io/*") | |||
| oidcValidRedirectURLs = flag.String("oidc-valid-redirect-urls", fmt.Sprintf("%s/*", *nebraskaURL), "OIDC valid Redirect URLs; accepts comma separated values and supports wildcards (*), for example http://nebraska.example.io/*. If not set defaults to <nebraska-url>/*") | |||
There was a problem hiding this comment.
I think it's easier if you set the oidcValidRedirectURLs as "" because this way you know already that it's not been set.
The docs make it explicit what it does if the user doesn't override it.
backend/cmd/nebraska/nebraska.go
Outdated
| @@ -165,6 +165,16 @@ func mainWithError() error { | |||
|
|
|||
| url.Path = "/login/cb" | |||
|
|
|||
| if (*nebraskaURL != "http://localhost:8000") && (*oidcValidRedirectURLs == "http://localhost:8000/*") { | |||
There was a problem hiding this comment.
With the oidcValidRedirectURLs as an empty string by default, this check becomes much simpler: if *oidcValidRedirectURLs == ""
This patch auto generates the default OIDC valid redirect URLs from the nebraska-url arg if the oidc-valid-redirect-urls is not provided``. Signed-off-by: Santhosh Nagaraj S <[email protected]>
yolossn
force-pushed
the
fix-oidc-valid-urls
branch
from
38e6249 to
b2d08f5
Compare
joaquimrocha
approved these changes
Jan 11, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch improves the help string of
oidc-valid-redirect-urls by adding explanation
for wildcard support.
Signed-off-by: Santhosh Nagaraj S [email protected]