kola/tests/ignition/oem: Cover more code paths in the initrd #421
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pothos
force-pushed
the
kai/initrd-oem-mount
branch
from
fb81d19 to
de87f07
Compare
pothos
force-pushed
the
kai/initrd-oem-mount
branch
4 times, most recently
from
a244a54 to
6886d18
Compare
pothos
force-pushed
the
kai/initrd-oem-mount
branch
from
6886d18 to
44cdc8f
Compare
krnowak
reviewed
Mar 20, 2023
krnowak
approved these changes
Mar 20, 2023
The mount unit for the OEM in the initrd gets triggered at different points when doing a reboot with Ignition, and in the current Flatcar versions this leads to a failure because Ignition can't mount when something else already triggered the mount unit.
pothos
force-pushed
the
kai/initrd-oem-mount
branch
from
44cdc8f to
e7b8c69
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The mount unit for the OEM in the initrd gets triggered at different points when doing a reboot with Ignition, and in the current Flatcar versions this leads to a failure because Ignition can't mount when something else already triggered the mount unit.
How to use
Should verify that flatcar/Flatcar#979 is fixed and doesn't come back
Testing done
Manually ran both tests for the image from flatcar/bootengine#58