Prevent the OEM mount point from showing up before Ignition mounts #58
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pothos
added a commit
to flatcar-archive/coreos-overlay
that referenced
this pull request
Mar 17, 2023
pothos
force-pushed
the
kai/initrd-oem-ordering
branch
from
f9156fe to
2fb5a75
Compare
pothos
added a commit
to flatcar-archive/coreos-overlay
that referenced
this pull request
Mar 18, 2023
pothos
changed the title
Ignition may run a manual mount command for the OEM partition if the user specifies it. This fails if the OEM mount unit is triggered early, because it can't be mounted twice, thus we need to prevent that from happening by unmounting the OEM partition (but not the tmpfs OEM mount for PXE-provided OEM contents). To spare users from even dealing with the OEM partition specification in Ignition we can ensure it is mounted before Ignition writes files.
pothos
force-pushed
the
kai/initrd-oem-ordering
branch
from
2fb5a75 to
2c99de8
Compare
pothos
added a commit
to flatcar-archive/coreos-overlay
that referenced
this pull request
Mar 20, 2023
This pulls in flatcar/bootengine#58 to prevent the OEM mount point from showing up before Ignition mounts. It also makes it simpler to write files to the OEM partition without having to specify the partition first as initrd mount point. Fixes flatcar/Flatcar#979
2 tasks
krnowak
reviewed
Mar 20, 2023
krnowak
approved these changes
Mar 20, 2023
pothos
added a commit
to flatcar-archive/coreos-overlay
that referenced
this pull request
Mar 20, 2023
This pulls in flatcar/bootengine#58 to prevent the OEM mount point from showing up before Ignition mounts. It also makes it simpler to write files to the OEM partition without having to specify the partition first as initrd mount point. Fixes flatcar/Flatcar#979
pothos
added a commit
to flatcar-archive/coreos-overlay
that referenced
this pull request
Mar 20, 2023
This pulls in flatcar/bootengine#58 to prevent the OEM mount point from showing up before Ignition mounts. It also makes it simpler to write files to the OEM partition without having to specify the partition first as initrd mount point. Fixes flatcar/Flatcar#979
|
Beta (3510) is also affected, I'll look into a backport before it goes Stable. Edit: Done, also had one additional single word change backported to ensure the ordering for initrd-setup-root when Ignition doesn't run. |
pothos
added a commit
that referenced
this pull request
Mar 23, 2023
Prevent the OEM mount point from showing up before Ignition mounts
pothos
added a commit
to flatcar-archive/coreos-overlay
that referenced
this pull request
Mar 23, 2023
This pulls in flatcar/bootengine#58 to prevent the OEM mount point from showing up before Ignition mounts. It also makes it simpler to write files to the OEM partition without having to specify the partition first as initrd mount point. Fixes flatcar/Flatcar#979
t-lo
pushed a commit
to flatcar/scripts
that referenced
this pull request
Apr 13, 2023
This pulls in flatcar/bootengine#58 to prevent the OEM mount point from showing up before Ignition mounts. It also makes it simpler to write files to the OEM partition without having to specify the partition first as initrd mount point. Fixes flatcar/Flatcar#979
t-lo
pushed a commit
to flatcar/scripts
that referenced
this pull request
Apr 13, 2023
This pulls in flatcar/bootengine#58 to prevent the OEM mount point from showing up before Ignition mounts. It also makes it simpler to write files to the OEM partition without having to specify the partition first as initrd mount point. Fixes flatcar/Flatcar#979
t-lo
pushed a commit
to flatcar/scripts
that referenced
this pull request
Apr 17, 2023
This pulls in flatcar/bootengine#58 to prevent the OEM mount point from showing up before Ignition mounts. It also makes it simpler to write files to the OEM partition without having to specify the partition first as initrd mount point. Fixes flatcar/Flatcar#979
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ignition may run a manual mount command for the OEM partition if the
user specifies it. This fails if the OEM mount unit is triggered early,
because it can't be mounted twice, thus we need to prevent that from
happening by unmounting the OEM partition (but not the tmpfs OEM mount
for PXE-provided OEM contents). To spare users from even dealing with
the OEM partition specification in Ignition we can ensure it is mounted
before Ignition writes files.
How to use
Testing done
Ran flatcar/mantle#421 manually for the image from http://jenkins.infra.kinvolk.io:8080/job/container/job/packages_all_arches/1516/cldsv/